You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/10/13 17:02:23 UTC
[GitHub] [solr-operator] j-coll opened a new pull request #343: Use global.imagePullSecrets at solr-operator helm chart #338
j-coll opened a new pull request #343:
URL: https://github.com/apache/solr-operator/pull/343
Same PR as #339, but against main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] j-coll commented on pull request #343: Use global.imagePullSecrets at solr-operator helm chart #338
Posted by GitBox <gi...@apache.org>.
j-coll commented on pull request #343:
URL: https://github.com/apache/solr-operator/pull/343#issuecomment-949802876
I saw a discrepancy between this "imagePullSecrets" and the one at the zookeeper-operator. I was expecting here a list of objects with "name", but the zookeeper-operator takes a list of strings
https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/values.yaml#L5-L8
Also, the operator is adding those to the service account, instead of the deployment itself:
https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/templates/service_account.yaml#L4-L9
https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/values.yaml#L23-L24
Which is more in line with your proposal here:
https://github.com/apache/solr-operator/pull/339#issuecomment-942424667
@hossman , do you have any preference on where to add the imagePullSecrets?
Should we try to be "as close as possible" to the zookeeper-operator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #343: Use global.imagePullSecrets at solr-operator helm chart #338
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #343:
URL: https://github.com/apache/solr-operator/pull/343#issuecomment-964366058
Well if you want to share imagePullSecrets here, you can merely use the same serviceAccount that is created by the Zookeeper Operator with the Solr Operator. That way the imagePullSecrets will be available to both through the same serviceAccount.
```yaml
serviceAccount:
create: false
name: operator-account
zookeeper-operator:
install: true
serviceAccount:
create: true
name: operator-account
imagePullSecrets:
- list
- of
- strings
```
Using the above helm values, the zookeeper-operator helm chart will create the serviceAccount with the listed imagePullSecrets. Then the Solr Operator will merely use the same one, named `operator-account`.
No need to actually use the global imagePullSecrets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org