You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 19:54:07 UTC

[GitHub] [arrow] kszucs commented on a change in pull request #8349: ARROW-3080: [Python] Unify Arrow to Python object conversion paths

kszucs commented on a change in pull request #8349:
URL: https://github.com/apache/arrow/pull/8349#discussion_r499835603



##########
File path: cpp/src/arrow/python/python_to_arrow.cc
##########
@@ -1004,6 +991,9 @@ Result<std::shared_ptr<ChunkedArray>> ConvertPySequence(PyObject* obj, PyObject*
   PyObject* seq;
   OwnedRef tmp_seq_nanny;
 
+  // FIXME(kszucs): shouldn't import pandas unconditionally

Review comment:
       We import pandas when converting from arrow to python in case of nanosecond resolution timestamp so to have successful roundtrip we need pandas to convert it back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org