You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by cvlchinet <gi...@git.apache.org> on 2014/12/02 18:10:41 UTC

[GitHub] thrift pull request: nodejs: Missing semicolon in thrift.js

GitHub user cvlchinet opened a pull request:

    https://github.com/apache/thrift/pull/300

    nodejs: Missing semicolon in thrift.js

    JSHint complains about missing semicolon. Might break older browser compatibility.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cvlchinet/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #300
    
----
commit fc677f440164957d69f04962e9e87578e3040cf7
Author: cvlchinet <cv...@chinet.info>
Date:   2014-12-02T17:10:08Z

    nodejs: Missing semicolon in thrift.js
    
    JSHint complains about missing semicolon. Might break older browser compatibility.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2871 - nodejs: Missing semicolon in th...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/300


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---