You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benedict (JIRA)" <ji...@apache.org> on 2018/09/20 18:16:00 UTC
[jira] [Updated] (CASSANDRA-14770) Introduce
RangesAtEndpoint.unwrap to simplify StreamSession.addTransferRanges
[ https://issues.apache.org/jira/browse/CASSANDRA-14770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benedict updated CASSANDRA-14770:
---------------------------------
Status: Patch Available (was: Open)
> Introduce RangesAtEndpoint.unwrap to simplify StreamSession.addTransferRanges
> -----------------------------------------------------------------------------
>
> Key: CASSANDRA-14770
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14770
> Project: Cassandra
> Issue Type: Improvement
> Components: Streaming and Messaging
> Reporter: Benedict
> Assignee: Benedict
> Priority: Trivial
> Fix For: 4.0
>
>
> Arguably, since this is only performed in one place, we could leave it in {{addTransferRanges}}, but it should be a helper method anyway, and given {{unwrap()}} is a feature of {{Range}}, we should implement that in {{RangesAtEndpoint}} IMO. I have introduced this method, which avoids allocating a new collection unnecessarily, corroborates we have at most one wrap-around range, and introduced unit tests for the method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org