You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Matthias Miller <ma...@invtools.com> on 2006/09/14 23:45:54 UTC

Re: Re: [PATCH] Improve mingw support

Max Bowsher wrote:
>> -#ifdef WIN32
>> +#if defined(WIN32) && !defined(__MINGW32__)
>>     
>
> From what I remember when I was more active in this sphere of things,
> adding a function to w32api should be pretty easy, so I'd suggest
> looking into that.
>   

I'm also quite interested in a MinGW build and am pursuing a patch for 
w32api.

>> * libsvn_subr/config_win.c: Define the minimum IE version to 5.0, since
>>      mingw32 doesn't seem to define this.
>>     
>> +#ifdef __MINGW32__
>> +# ifndef _WIN32_IE
>> +#  define _WIN32_IE 0x0500
>> +# endif
>> +#endif
>>     
>
> That doesn't seem right at all. If we are setting these 'API level
> feature request' macros at all, we should be setting them for all
> windows compilers.
>   

Also, we should define this macro before we include windows.h. I've 
attached an updated patch, but I don't have a VC build environment, so I 
can't confirm that it builds correctly there. It does the trick under MinGW.

-Matthias Miller