You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/17 12:28:10 UTC
[GitHub] [arrow] liyafan82 opened a new pull request #10949: ARROW-13645 [Java]: Allow NullVectors to have distinct field names
liyafan82 opened a new pull request #10949:
URL: https://github.com/apache/arrow/pull/10949
As discussed in the ML (https://lists.apache.org/thread.html/r19aad8a34f63334d3fcd627106f69be13f689740b83930a4eecc17b3%40%3Cdev.arrow.apache.org%3E), the current implementation use hard-coded field names. This may cause some problems, for example, when reconstruct a usable schema from a list of FieldVectors.
So we resolve this problem by allowing NullVectors to have distinct field names.
This also makes the NullVector with other types of vectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #10949: ARROW-13645 [Java]: Allow NullVectors to have distinct field names
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #10949:
URL: https://github.com/apache/arrow/pull/10949#issuecomment-901675403
> LGTM
> nit: The last line of the description may have a typo, `This also makes the ZeroVector with other types of vectors.` looks correct based on the change.
@kiszk Thanks for your feedback. I have updated the description accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 closed pull request #10949: ARROW-13645 [Java]: Allow NullVectors to have distinct field names
Posted by GitBox <gi...@apache.org>.
liyafan82 closed pull request #10949:
URL: https://github.com/apache/arrow/pull/10949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #10949: ARROW-13645 [Java]: Allow NullVectors to have distinct field names
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #10949:
URL: https://github.com/apache/arrow/pull/10949#issuecomment-904296650
> I still see `NullVector` instead of `ZeroVector`. But, it is nit.
@kiszk Thanks for your careful review.
According to the current implementation, `ZeroVector` is a sub-class of `NullVector`, and the patch applies to both `ZeroVector` and `NullVector`. So I used the more general term (`NullVector`) here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10949: ARROW-13645 [Java]: Allow NullVectors to have distinct field names
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10949:
URL: https://github.com/apache/arrow/pull/10949#issuecomment-900254315
https://issues.apache.org/jira/browse/ARROW-13645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #10949: ARROW-13645 [Java]: Allow NullVectors to have distinct field names
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #10949:
URL: https://github.com/apache/arrow/pull/10949#issuecomment-903946860
I still see `NullVector` instead of `ZeroVector`. But, it is nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #10949: ARROW-13645 [Java]: Allow NullVectors to have distinct field names
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #10949:
URL: https://github.com/apache/arrow/pull/10949#issuecomment-901294548
LGTM
nit: The last line of the description may have a typo, `This also makes the ZeroVector with other types of vectors.` looks correct based on the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org