You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Raul Gutierrez Segales <rg...@itevenworks.net> on 2015/06/01 18:21:39 UTC
Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation
and doc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33713/#review85994
-----------------------------------------------------------
src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
<https://reviews.apache.org/r/33713/#comment137836>
how about we put these two properties (checkIntervalMs and maxPerMinute) under znode.container.* ?
the reasons for this are:
a) container is becoming a pretty ubiquitous term, so to prevent any sort of future ambiguity
b) it probably makes sense to group properties that define how we treat znodes (in general and special ones, like container znodes)
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
<https://reviews.apache.org/r/33713/#comment137831>
line too long, assing zkdb first:
```java
ZKDatabase zkdb = serverFactory.getZooKeeperServer().getZKDatabase();
...
```
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
<https://reviews.apache.org/r/33713/#comment137832>
ditto
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
<https://reviews.apache.org/r/33713/#comment137833>
ditto
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
<https://reviews.apache.org/r/33713/#comment137834>
ditto
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
<https://reviews.apache.org/r/33713/#comment137835>
ditto
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
<https://reviews.apache.org/r/33713/#comment137829>
line too long, save zkDB and pass that:
```java
ZKDatabase zkdb = serverFactory.getZooKeeperServer().getZKDatabase();
final ContainerManager cm = new ContainerManager(zkdb, ...) {
};
```
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
<https://reviews.apache.org/r/33713/#comment137827>
newline between methods
- Raul Gutierrez Segales
On May 30, 2015, 12:19 a.m., Jordan Zimmerman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33713/
> -----------------------------------------------------------
>
> (Updated May 30, 2015, 12:19 a.m.)
>
>
> Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales.
>
>
> Bugs: ZOOKEEPER-2163
> https://issues.apache.org/jira/browse/ZOOKEEPER-2163
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> Introduce new ZNode type: container
>
>
> Diffs
> -----
>
> src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 5401157
> src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 218baf3
> src/java/main/org/apache/zookeeper/CreateMode.java d87f410
> src/java/main/org/apache/zookeeper/MultiTransactionRecord.java ca7dd98
> src/java/main/org/apache/zookeeper/Op.java 97d3d7b
> src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331
> src/java/main/org/apache/zookeeper/ZooKeeper.java fdee4e6
> src/java/main/org/apache/zookeeper/cli/CreateCommand.java c6de7c6
> src/java/main/org/apache/zookeeper/server/ContainerManager.java PRE-CREATION
> src/java/main/org/apache/zookeeper/server/DataNode.java b341a69
> src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 7e3c29f
> src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 0e8133e
> src/java/main/org/apache/zookeeper/server/Request.java bed9b13
> src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d
> src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0
> src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java cf0900b
> src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 4d061f4
> src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 6434d02
> src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 36a23ee
> src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java a49319c
> src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e
> src/java/test/org/apache/zookeeper/server/CreateContainerTest.java PRE-CREATION
> src/java/test/org/apache/zookeeper/test/CreateModeTest.java 9db01bb
> src/zookeeper.jute 921f658
>
> Diff: https://reviews.apache.org/r/33713/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jordan Zimmerman
>
>