You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (JIRA)" <ji...@apache.org> on 2010/08/31 07:21:53 UTC
[jira] Created: (THRIFT-881) add csharp to the tutorial
add csharp to the tutorial
--------------------------
Key: THRIFT-881
URL: https://issues.apache.org/jira/browse/THRIFT-881
Project: Thrift
Issue Type: Improvement
Components: C# - Compiler, C# - Library
Reporter: Roger Meier
Priority: Minor
It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-881) add csharp to the tutorial
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-881:
-------------------------------
Attachment: THRIFT-881_csharp_tutorial.patch
here's the patch for the tutorial...
client+server stolen from test dir and slightly modified;-)
tested with Visual Studio 2008 on Windows XP
{code}
D test/csharp/CSharpClient.cs
D test/csharp/CSharpServer.cs
A tutorial/csharp
A tutorial/csharp/CsharpClient
A tutorial/csharp/CsharpClient/CsharpClient.cs
A tutorial/csharp/CsharpClient/Properties
A tutorial/csharp/CsharpClient/Properties/AssemblyInfo.cs
A tutorial/csharp/CsharpClient/CsharpClient.csproj
A tutorial/csharp/CsharpServer
A tutorial/csharp/CsharpServer/CsharpServer.csproj
A tutorial/csharp/CsharpServer/CsharpServer.cs
A tutorial/csharp/CsharpServer/Properties
A tutorial/csharp/CsharpServer/Properties/AssemblyInfo.cs
A tutorial/csharp/tutorial.sln
{code}
> add csharp to the tutorial
> --------------------------
>
> Key: THRIFT-881
> URL: https://issues.apache.org/jira/browse/THRIFT-881
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Roger Meier
> Priority: Minor
> Attachments: THRIFT-881_csharp_tutorial.patch
>
>
> It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
> see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-881) add csharp to the tutorial
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913960#action_12913960 ]
Roger Meier commented on THRIFT-881:
------------------------------------
Could you commit this for 0.5? Or what's missing here?
moving these tutorial files out from test to tutorial helps fixing THRIFT-35 (Move language tests into their appropriate library directory) as well.
> add csharp to the tutorial
> --------------------------
>
> Key: THRIFT-881
> URL: https://issues.apache.org/jira/browse/THRIFT-881
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Roger Meier
> Priority: Minor
> Attachments: THRIFT-881_csharp_tutorial.patch
>
>
> It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
> see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-881) add csharp to the tutorial
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-881:
-------------------------------
Attachment: THRIFT-881_csharp_tutorial.v2.patch
[^THRIFT-881_csharp_tutorial.v2.patch] populates AssemblyCopyright with Apache Foundation and removes strange character there.
The versioning is still the same due to the following reasons:
* THRIFT-6 is still open => how to get the VERSION to the libraries in general?
* C# users usually do not use make, so AssemblyInfo.cs.in or something like that would break their workflow
* not that important for a tutorial ;-)
> add csharp to the tutorial
> --------------------------
>
> Key: THRIFT-881
> URL: https://issues.apache.org/jira/browse/THRIFT-881
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Roger Meier
> Priority: Minor
> Attachments: THRIFT-881_csharp_tutorial.patch, THRIFT-881_csharp_tutorial.v2.patch
>
>
> It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
> see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-881) add csharp to the tutorial
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-881.
--------------------------------
Assignee: Roger Meier
Fix Version/s: 0.5
Resolution: Fixed
I just committed this. Thanks for the patch, Roger!
> add csharp to the tutorial
> --------------------------
>
> Key: THRIFT-881
> URL: https://issues.apache.org/jira/browse/THRIFT-881
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Roger Meier
> Assignee: Roger Meier
> Priority: Minor
> Fix For: 0.5
>
> Attachments: THRIFT-881_csharp_tutorial.patch, THRIFT-881_csharp_tutorial.v2.patch
>
>
> It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
> see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-881) add csharp to the tutorial
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912492#action_12912492 ]
Bryan Duxbury commented on THRIFT-881:
--------------------------------------
Why are the client and server from the test dir being deleted? Are they unused there?
> add csharp to the tutorial
> --------------------------
>
> Key: THRIFT-881
> URL: https://issues.apache.org/jira/browse/THRIFT-881
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Roger Meier
> Priority: Minor
> Attachments: THRIFT-881_csharp_tutorial.patch
>
>
> It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
> see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-881) add csharp to the tutorial
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912650#action_12912650 ]
Roger Meier commented on THRIFT-881:
------------------------------------
Yes, it's a move of files from test to the tutorial directory. The place where these files should be.
In addition there are some new Visual Studio project files to make live easier.
> add csharp to the tutorial
> --------------------------
>
> Key: THRIFT-881
> URL: https://issues.apache.org/jira/browse/THRIFT-881
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Roger Meier
> Priority: Minor
> Attachments: THRIFT-881_csharp_tutorial.patch
>
>
> It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
> see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-881) add csharp to the tutorial
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914068#action_12914068 ]
Michael Greene commented on THRIFT-881:
---------------------------------------
This makes sense to me. A couple of suggestions:
- the "Copyright © 2010" in the csproj files should probably be assigned to ASF and also not use those odd characters.
- it would be helpful to add Makefiles for them so a top level make check could incorporate them.
> add csharp to the tutorial
> --------------------------
>
> Key: THRIFT-881
> URL: https://issues.apache.org/jira/browse/THRIFT-881
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Roger Meier
> Priority: Minor
> Attachments: THRIFT-881_csharp_tutorial.patch
>
>
> It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
> see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-881) add csharp to the tutorial
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912498#action_12912498 ]
Michael Greene commented on THRIFT-881:
---------------------------------------
They do essentially the same thing. Roger's patch is mostly a move, with Visual Studio project files being added.
> add csharp to the tutorial
> --------------------------
>
> Key: THRIFT-881
> URL: https://issues.apache.org/jira/browse/THRIFT-881
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Roger Meier
> Priority: Minor
> Attachments: THRIFT-881_csharp_tutorial.patch
>
>
> It would be a nice benefit for people get started with thrift to have a csharp example within the tutorial.
> see http://svn.apache.org/viewvc/incubator/thrift/trunk/tutorial/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.