You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by se...@apache.org on 2015/04/03 23:55:41 UTC

incubator-reef git commit: [REEF-239] Catch all Throwables when trying to create symlinks

Repository: incubator-reef
Updated Branches:
  refs/heads/master 66b9195a6 -> 940752b9f


[REEF-239] Catch all Throwables when trying to create symlinks

This attempts to copy files if the symbolic linking throws any
`Throwable`, not just `IOException`.

JIRA:
  [REEF-239](https://issues.apache.org/jira/browse/REEF-239)

Pull Request:
  This closes #135


Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/940752b9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/940752b9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/940752b9

Branch: refs/heads/master
Commit: 940752b9ff791a20f6b159fe550a30f9b992ed4a
Parents: 66b9195
Author: Markus Weimer <we...@apache.org>
Authored: Fri Apr 3 14:20:27 2015 -0700
Committer: Beysim Sezgin <be...@microsoft.com>
Committed: Fri Apr 3 14:53:41 2015 -0700

----------------------------------------------------------------------
 .../java/org/apache/reef/runtime/local/client/DriverFiles.java    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/940752b9/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java
index 06262e4..c54f9e0 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java
@@ -141,7 +141,8 @@ final class DriverFiles {
       this.localLibs.createSymbolicLinkTo(localFolder);
       this.globalLibs.createSymbolicLinkTo(globalFolder);
       this.globalFiles.createSymbolicLinkTo(globalFolder);
-    } catch (IOException e) {
+    } catch (final Throwable t) {
+      LOG.log(Level.FINE, "Can't symlink the files, copying them instead.", t);
       this.localFiles.copyTo(localFolder);
       this.localLibs.copyTo(localFolder);
       this.globalLibs.copyTo(globalFolder);