You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (JIRA)" <ji...@apache.org> on 2018/03/16 09:36:00 UTC
[jira] [Commented] (LUCENE-8212) Never swallow Exceptions in
IndexWriter and DocumentsWriter
[ https://issues.apache.org/jira/browse/LUCENE-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401671#comment-16401671 ]
Simon Willnauer commented on LUCENE-8212:
-----------------------------------------
here is also a github link for easier reviews https://github.com/s1monw/lucene-solr/pull/5
> Never swallow Exceptions in IndexWriter and DocumentsWriter
> ------------------------------------------------------------
>
> Key: LUCENE-8212
> URL: https://issues.apache.org/jira/browse/LUCENE-8212
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 7.4, master (8.0)
> Reporter: Simon Willnauer
> Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: LUCENE-8212.patch
>
>
> IndexWriter as well as DocumentsWriter caught Throwable and ignored it. This is mainly a relict from pre Java 7 were exceptions didn't have the needed API to suppress exceptions. This change handles exceptions correctly where the original exception is rethrown and all other exceptions are added as suppressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org