You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by grossws <gi...@git.apache.org> on 2015/07/06 18:58:12 UTC
[GitHub] lucene-solr pull request: Fix misleading reference of Uninvert fie...
GitHub user grossws opened a pull request:
https://github.com/apache/lucene-solr/pull/183
Fix misleading reference of Uninvert field
docsWithField referenced on L276 without `this` in `FieldCacheImpl.Uninvert#uninvert(...)` is object field but several lines below variable with same name is defined and same field is used with `this`. It's quite misleading when reading code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grossws/lucene-solr patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit d4e397092fd444268bc50b063384013fa22e27c0
Author: grossws <gr...@gmail.com>
Date: 2015-07-06T16:58:01Z
Fix misleading reference of Uninvert field
docsWithField referenced on L276 without `this` in `FieldCacheImpl.Uninvert#uninvert(...)` is object field but several lines below variable with same name is defined and same field is used with `this`. It's quite misleading when reading code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Fix misleading reference of Uninvert fie...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #183: LUCENE-7778 Removed synchronized from RAMFile...
Posted by spmason <gi...@git.apache.org>.
Github user spmason closed the pull request at:
https://github.com/apache/lucene-solr/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org