[GitHub] [beam] boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

[GitBox <gi...@apache.org>]

boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker
URL: https://github.com/apache/beam/pull/11418#discussion_r408483381
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java
 ##########
 @@ -49,13 +50,22 @@ public OffsetRange currentRestriction() {
 
   @Override
   public SplitResult<OffsetRange> trySplit(double fractionOfRemainder) {
-    // TODO(BEAM-8872): Add support for splitting off a fixed amount of work for this restriction
-    // instead of only supporting checkpointing.
-
-    checkState(
-        lastClaimedOffset != null, "Can't checkpoint before any offset was successfully claimed");
-    OffsetRange res = new OffsetRange(lastClaimedOffset + 1, range.getTo());
-    this.range = new OffsetRange(range.getFrom(), lastClaimedOffset + 1);
+    checkState(lastClaimedOffset != null, "Can't split before any offset was successfully claimed");
 
 Review comment:
   Allowing split before first claiming makes sense to me. Python has already allowed that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services