[jira] [Comment Edited] (HBASE-10292) TestRegionServerCoprocessorExceptionWithAbort fails occasionally

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865162#comment-13865162 ] 

Andrew Purtell edited comment on HBASE-10292 at 1/8/14 7:21 AM:
----------------------------------------------------------------

Here:

{code}
-      fail("The put should have failed, as the coprocessor is buggy");
-    } catch (IOException ignored) {
-      // Expected.
+      table.flushCommits();
+    } catch (RetriesExhaustedWithDetailsException e) {
+      threwIOE = true;
+    } finally {
+      assertTrue("The regionserver should have thrown an exception", threwIOE);
{code}

I suppose I could put IOException in for RetriesExhaustedWithDetailsException to paper over details that may change (but still subclass IOE). That was an auto-completion and what the other TestRegionServerCoprocessorExceptionWithFoo test does so I left it.


was (Author: apurtell):
Here:

{code}
-      fail("The put should have failed, as the coprocessor is buggy");
-    } catch (IOException ignored) {
-      // Expected.
+      table.flushCommits();
+    } catch (RetriesExhaustedWithDetailsException e) {
+      threwIOE = true;
+    } finally {
+      assertTrue("The regionserver should have thrown an exception", threwIOE);
{code}

I suppose I could put IOException in for RetriesExhaustedWithDetailsException. That was an auto-completion and what the other TestRegionServerCoprocessorExceptionWithFoo test does so I left it.

> TestRegionServerCoprocessorExceptionWithAbort fails occasionally
> ----------------------------------------------------------------
>
>                 Key: HBASE-10292
>                 URL: https://issues.apache.org/jira/browse/HBASE-10292
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.98.0
>
>         Attachments: 10292.patch
>
>
> TestRegionServerCoprocessorExceptionWithAbort has occasionally failed for a very long time now. Fix or disable.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)