You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by rm...@apache.org on 2017/02/28 05:03:42 UTC
ranger git commit: RANGER-1406: Audit spoolfile not getting created
when ranger service user didn't have permission to log into Solr
Repository: ranger
Updated Branches:
refs/heads/master cd4dbcbde -> 6326d01ca
RANGER-1406: Audit spoolfile not getting created when ranger service user didn't have permission to log into Solr
Project: http://git-wip-us.apache.org/repos/asf/ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/6326d01c
Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/6326d01c
Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/6326d01c
Branch: refs/heads/master
Commit: 6326d01ca0eea73b48e1f008d5557604bdd48b3d
Parents: cd4dbcb
Author: rmani <rm...@hortonworks.com>
Authored: Thu Feb 23 23:01:46 2017 -0800
Committer: rmani <rm...@hortonworks.com>
Committed: Mon Feb 27 21:03:24 2017 -0800
----------------------------------------------------------------------
.../apache/ranger/audit/destination/SolrAuditDestination.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ranger/blob/6326d01c/agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
----------------------------------------------------------------------
diff --git a/agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java b/agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
index 405cfee..e689e5d 100644
--- a/agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
+++ b/agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
@@ -199,6 +199,7 @@ public class SolrAuditDestination extends AuditDestination {
@Override
public boolean log(Collection<AuditEventBase> events) {
+ boolean ret = false;
try {
logStatusIfRequired();
addTotalCount(events.size());
@@ -208,7 +209,7 @@ public class SolrAuditDestination extends AuditDestination {
if (solrClient == null) {
// Solr is still not initialized. So need return error
addDeferredCount(events.size());
- return false;
+ return ret;
}
}
@@ -233,6 +234,7 @@ public class SolrAuditDestination extends AuditDestination {
logFailedEvent(events, response.toString());
} else {
addSuccessCount(events.size());
+ ret = true;
}
} catch (SolrException ex) {
addFailedCount(events.size());
@@ -241,9 +243,8 @@ public class SolrAuditDestination extends AuditDestination {
} catch (Throwable t) {
addDeferredCount(events.size());
logError("Error sending message to Solr", t);
- return false;
}
- return true;
+ return ret;
}
/*