You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/20 09:45:40 UTC

[GitHub] [thrift] emmenlau commented on issue #2094: THRIFT-5109: Misc CMake build improvements

emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616435582


   I've found a small improvement where the Javascript target actually depends on the target that copies the compiler into the source tree, not on the build of the compiler. This ensures that if the compiler is *not* built, it will still be copied.
   
   If the CI is now successful, this should be ready for review / merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org