You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/20 09:56:00 UTC
[jira] [Work logged] (FILEUPLOAD-341) Move exceptions out of .impl
package
[ https://issues.apache.org/jira/browse/FILEUPLOAD-341?focusedWorklogId=640184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640184 ]
ASF GitHub Bot logged work on FILEUPLOAD-341:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/21 09:55
Start Date: 20/Aug/21 09:55
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #108:
URL: https://github.com/apache/commons-fileupload/pull/108#issuecomment-902578744
[](https://coveralls.io/builds/42293956)
Coverage remained the same at 78.117% when pulling **4f26f288bf5141791a232ee915b0f9938776b6c8 on martin-g:FILEUPLOAD-341-add-migration-notes-for-340-and-341** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 640184)
Remaining Estimate: 0h
Time Spent: 10m
> Move exceptions out of .impl package
> ------------------------------------
>
> Key: FILEUPLOAD-341
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341
> Project: Commons FileUpload
> Issue Type: Wish
> Affects Versions: 2.0
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Jochen Wiedmann
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that exports all packages but org.apache.commons.fileupload2.impl.
>
> Would it be OK to move all **Exception classes to the parent package so that they are visible by users ?
> **Impl classes should stay in org.apache.commons.fileupload2.impl!
>
> In Apache Wicket we use few of the exception classes to report specific errors:
> * [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505]
> * [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)