You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/31 02:59:33 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10269: [Feature][Task Plugin] Add support for dynamic form in zeppelin task

EricGao888 commented on code in PR #10269:
URL: https://github.com/apache/dolphinscheduler/pull/10269#discussion_r885165289


##########
dolphinscheduler-ui/src/views/projects/task/components/node/format-data.ts:
##########
@@ -315,6 +315,7 @@ export function formatParams(data: INodeData): {
   if (data.taskType === 'ZEPPELIN') {
     taskParams.noteId = data.zeppelinNoteId
     taskParams.paragraphId = data.zeppelinParagraphId
+    taskParams.parameters = data.parameters

Review Comment:
   @Amy0104 I've tested locally and it looks fine. Not sure what `tsc` mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org