You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/01/29 22:45:46 UTC
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1564
[FLINK-3160] [web-dashboard] Aggregate operator statistics by TaskManager
Adds a new per-job tab displaying task statistics aggregated by TaskManager
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3160_aggregate_operator_statistics_by_taskmanager
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1564.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1564
----
commit b5560010e6d1535b67d8077c418861c87518e803
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-01-28T18:11:39Z
[FLINK-3160] [web-dashboard] Aggregate operator statistics by TaskManager
Adds a new per-job tab displaying task statistics aggregated by TaskManager
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1564#issuecomment-182814031
Changes and screenshots look very good!
I have a minor inline comment regarding the added method. After addressing it, I think that this is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1564
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1564#issuecomment-184105956
Thank you Greg! Let me try this out once more and then merge it if everything works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1564#discussion_r52588713
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java ---
@@ -203,6 +204,27 @@ public JobVertexID getJobVertexId() {
public ExecutionVertex[] getTaskVertices() {
return taskVertices;
}
+
+ public Map<String, List<ExecutionVertex>> getTaskVerticesByTaskManager() {
--- End diff --
Can we move this to the handler? I think that will be the only place where we use it in the future as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1564#issuecomment-177597755
Could you describe what exactly the change looks like, share a few screenshots of the parts that changed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1564#discussion_r52588212
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.jade ---
@@ -22,7 +22,10 @@
nav.navbar.navbar-default.navbar-secondary-additional
ul.nav.nav-tabs
li(ui-sref-active='active')
- a(ui-sref=".overview({nodeid: nodeid})") Overview
+ a(ui-sref=".overview({nodeid: nodeid})") Subtasks
--- End diff --
Should we rename the `overview` ref to `subtasks` as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1564#issuecomment-178124299
Running WordCount on a single node running two taskmanagers, the first screenshot is the current UI (with 'Overview' renamed to 'Subtasks') and the second screenshot is the new tab for 'TaskManagers'.
Hostname is appended with port in both tabs in order to disambiguate TaskManagers, although this deserves further consideration. It would be cleaner to use a per-host index for TaskManagers rather than the 5-digit port (ie., 127.0.0.1:0, 127.0.0.1:1, ...).
Subtasks and TaskManagers are now sorted by host.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1564#issuecomment-183066952
@uce I rebased, made the noted changes, and updated the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3160] [web-dashboard] Aggregate operato...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1564#issuecomment-179313154
I did not look at the code, but the screenshots look very good.
+1 for renaming "Overview" to "Subtasks" and adding the TaskManager tab.
I'm OK with using ports for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---