Re: [PR] fix: preserve null semantics in expression simplification [datafusion]

["fzlzjerry (via GitHub)" <gi...@apache.org>]

fzlzjerry commented on PR #24258:
URL: https://github.com/apache/datafusion/pull/24258#issuecomment-5497465235

   Rebased onto the current `main` and fixed the SQLite-suite regression from the previous head. `EliminateFilter` now only drops the other side of `NULL`/`FALSE AND ...` when that expression is known safe to discard; potentially fallible expressions remain in the predicate, preserving runtime errors such as division by zero. I added optimizer and SQLLogicTest coverage for both operand orders.
   
   Validated on `c6dc40034` with:
   
   - `cargo fmt --all -- --check`
   - `cargo clippy --all-targets --all-features -- -D warnings`
   - the full `datafusion-optimizer` and `datafusion-functions-nested` library test suites (770 + 115 tests)
   - the affected `predicates` / `simplify_expr` SQLLogicTests
   - all nine SQLite files reported by the failed CI job
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org