You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2024/01/16 17:27:16 UTC
[PR] fix(crd): Remove traits default values [camel-k]
gansheer opened a new pull request, #5075:
URL: https://github.com/apache/camel-k/pull/5075
Closes #5060
* Rollback default values added by PR https://github.com/apache/camel-k/pull/4887 .
* Add non-regressions tests on traits to avoid having non-explicit values in integration test definitions
Note : should re-open #4726
**Release Note**
```release-note
fix(crd): Remove traits default values
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(crd): Remove traits default values [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #5075:
URL: https://github.com/apache/camel-k/pull/5075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(crd): Remove traits default values [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5075:
URL: https://github.com/apache/camel-k/pull/5075#discussion_r1453753115
##########
e2e/common/config/config_test.go:
##########
@@ -120,6 +122,16 @@ func TestRunConfigExamples(t *testing.T) {
Eventually(IntegrationPodPhase(ns, "property-secret-route"), TestTimeoutLong).Should(Equal(corev1.PodRunning))
Eventually(IntegrationConditionStatus(ns, "property-secret-route", v1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionTrue))
Eventually(IntegrationLogs(ns, "property-secret-route"), TestTimeoutShort).Should(ContainSubstring("my-secret-external-value"))
+
+ // check integration schema does not contains unwanted default trait value.
+ gvk := schema.GroupVersionKind{Group: v1.SchemeGroupVersion.Group, Version: v1.SchemeGroupVersion.Version, Kind: v1.IntegrationKind}
Review Comment:
I see this is duplicated everywhere. Create a test support function in order to avoid too much duplication and difficulty in code reading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(crd): Remove traits default values [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5075:
URL: https://github.com/apache/camel-k/pull/5075#issuecomment-1894209149
:heavy_check_mark: Unit test coverage report - coverage increased from 34.4% to 34.8% (**+0.4%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org