You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2017/09/21 14:44:02 UTC
[GitHub] nifi pull request #2167: NIFI-4403 - add group name to bulletins model & S2S...
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2167
NIFI-4403 - add group name to bulletins model & S2S bulletin reporting task
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-4403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2167.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2167
----
commit f93ea715eb186519579d3bbfa8ab230aa4e28143
Author: Pierre Villard <pi...@gmail.com>
Date: 2017-09-21T12:12:29Z
NIFI-4403 - add group name to bulletins model
----
---
[GitHub] nifi issue #2167: NIFI-4403 - add group name to bulletins model & S2S bullet...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2167
I don't think we can always add the group name to the BulletinDTO. A user could have permissions to the component generating the bulletin but not the Process Group the component lives in. Adding it to the Bulletin model server-side and exposed via the ReportingContext should ok though.
FYI - The source name is fair game as the BulletinDto is not set in the BulletinEntity when they lack permissions to the source.
---
[GitHub] nifi issue #2167: NIFI-4403 - add group name to bulletins model & S2S bullet...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2167
That is correct. Knowledge of the components (UUID, status, etc) is allowed. Knowledge of what those components are/how they are configured is not.
---
[GitHub] nifi issue #2167: NIFI-4403 - add group name to bulletins model & S2S bullet...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2167
Good point. Just to be sure: we allow the user to see the group UUID but we don't want to make readable the associated group name. Right? I'll remove the group name reference in bulletin entity and bulletin dto.
---
[GitHub] nifi pull request #2167: NIFI-4403 - add group name to bulletins model & S2S...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2167
---
[GitHub] nifi issue #2167: NIFI-4403 - add group name to bulletins model & S2S bullet...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2167
Thanks @mcgilman - it should be OK now: group name is only on server side and only exposed through the reporting task.
---