You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/02/25 22:42:01 UTC

[GitHub] couchdb-chttpd pull request: Rename system databases

GitHub user kxepal opened a pull request:

    https://github.com/apache/couchdb-chttpd/pull/27

    Rename system databases

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kxepal/couchdb-chttpd rename-system-databases

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-chttpd/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit 7fef96e011af4200b2a98db9e40ac23ebe21ac78
Author: Alexander Shorin <kx...@apache.org>
Date:   2015-02-25T21:39:45Z

    Add underscore prefix for dbs database name
    
    That's how we name system databases and there should be no exceptions.
    
    COUCHDB-2619

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request: Rename system databases

Posted by chewbranca <gi...@git.apache.org>.

Github user chewbranca commented on the pull request:

    https://github.com/apache/couchdb-chttpd/pull/27#issuecomment-76228254
  
    Looks like there's a discrepancy on the naming of the config value. The subfield should be `shards_db` (plural) not `shard_db`. I'm treating the plural version as canonical because that's what [mem3_shards.erl](https://github.com/apache/couchdb-mem3/blob/master/src/mem3_shards.erl#L228-L229) uses when it creates the database.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request: Rename system databases

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-chttpd/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request: Rename system databases

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-chttpd/pull/27#issuecomment-76234243
  
    @chewbranca nice found! fixed it in https://github.com/kxepal/couchdb-mem3/commit/b727f2d969040040357c06b3cf7f7158b42f7bac for https://github.com/apache/couchdb-mem3/pull/6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---