You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/09/18 07:47:34 UTC
[GitHub] [systemds] sebwrede opened a new pull request #1057: Fix FederatedWorkerHandlerTest
sebwrede opened a new pull request #1057:
URL: https://github.com/apache/systemds/pull/1057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1057: Fix FederatedWorkerHandlerTest
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1057:
URL: https://github.com/apache/systemds/pull/1057#issuecomment-694771255
> The failing tests could be caused by the shared target space used by both federated and privacy tests. The tests never fail when I run it locally and they only fail sometimes when running it through GitHub Actions, so even if the privacy tests pass now, we cannot know for sure if we only run it once. I fixed FederatedWorkerHandlerTest to use its own target space and I believe this has fixed the problem.
sounds reasonable, Lets try it out, we will see if it becomes stable by following commits!
also the pr LGTM, will merge shortly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] sebwrede commented on pull request #1057: Fix FederatedWorkerHandlerTest
Posted by GitBox <gi...@apache.org>.
sebwrede commented on pull request #1057:
URL: https://github.com/apache/systemds/pull/1057#issuecomment-694763705
The failing tests could be caused by the shared target space used by both federated and privacy tests. The tests never fail when I run it locally and they only fail sometimes when running it through GitHub Actions, so even if the privacy tests pass now, we cannot know for sure if we only run it once. I fixed FederatedWorkerHandlerTest to use its own target space and I believe this has fixed the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1057: Fix FederatedWorkerHandlerTest
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1057:
URL: https://github.com/apache/systemds/pull/1057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org