You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2022/01/12 10:03:00 UTC

[jira] [Commented] (JCRVLT-590) Remove finalizer in ZipVaultPackage

    [ https://issues.apache.org/jira/browse/JCRVLT-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474413#comment-17474413 ] 

Julian Reschke commented on JCRVLT-590:
---------------------------------------

Is there any likelihood that this will break existing systems?

If so, it might be good to make the contract change, and *change* the finalizer to report (ERROR) unclosed packages (maybe with name and call stack of instantiation).

> Remove finalizer in ZipVaultPackage
> -----------------------------------
>
>                 Key: JCRVLT-590
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-590
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: vlt
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: 3.5.10
>
>
> Instead of relying on the finalizer in https://github.com/apache/jackrabbit-filevault/blob/561aaa092d721963f16b860de955e6d1752a350e/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L322-L329, every ZipVaultPackage should be explicitly closed



--
This message was sent by Atlassian Jira
(v8.20.1#820001)