You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 02:04:20 UTC

[GitHub] [arrow-datafusion] NGA-TRAN opened a new pull request, #2231: chore: add debug log

NGA-TRAN opened a new pull request, #2231:
URL: https://github.com/apache/arrow-datafusion/pull/2231

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] NGA-TRAN commented on pull request #2231: chore: add `debug!` log in some execution operators

Posted by GitBox <gi...@apache.org>.
NGA-TRAN commented on PR #2231:
URL: https://github.com/apache/arrow-datafusion/pull/2231#issuecomment-1099497113

   @alamb I have addressed your comment and it is ready to merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] NGA-TRAN commented on a diff in pull request #2231: chore: add `debug!` log in some execution operators

Posted by GitBox <gi...@apache.org>.
NGA-TRAN commented on code in PR #2231:
URL: https://github.com/apache/arrow-datafusion/pull/2231#discussion_r850681558


##########
datafusion/core/src/physical_plan/filter.rs:
##########
@@ -133,8 +134,8 @@ impl ExecutionPlan for FilterExec {
         partition: usize,
         context: Arc<TaskContext>,
     ) -> Result<SendableRecordBatchStream> {
+        debug!("Start FilterExec::execute for partition: {}", partition);

Review Comment:
   working on adding it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #2231: chore: add `debug!` log in some execution operators

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2231:
URL: https://github.com/apache/arrow-datafusion/pull/2231#issuecomment-1099617552

   
   > For these type of logs, it might be interesting to see if it makes sense to use the tracing crate for instrumenting the code.
   
   
   We use the tracing crate in IOx and it works quite well for us


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on pull request #2231: chore: add `debug!` log in some execution operators

Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #2231:
URL: https://github.com/apache/arrow-datafusion/pull/2231#issuecomment-1099572190

   Thanks @NGA-TRAN !
   
   For these type of logs, it might be interesting to see if it makes sense to use the `tracing` crate for instrumenting the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #2231: chore: add `debug!` log in some execution operators

Posted by GitBox <gi...@apache.org>.
alamb merged PR #2231:
URL: https://github.com/apache/arrow-datafusion/pull/2231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2231: chore: add debug log

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2231:
URL: https://github.com/apache/arrow-datafusion/pull/2231#discussion_r850662282


##########
datafusion/core/src/physical_plan/filter.rs:
##########
@@ -133,8 +134,8 @@ impl ExecutionPlan for FilterExec {
         partition: usize,
         context: Arc<TaskContext>,
     ) -> Result<SendableRecordBatchStream> {
+        debug!("Start FilterExec::execute for partition: {}", partition);

Review Comment:
   I wonder if it would be useful to log `context` as well (perhaps `session_id` and `task_id`)?
   
   https://github.com/apache/arrow-datafusion/blob/7a6317a0e31829ab06669a57987272b97e4694f4/datafusion/core/src/execution/context.rs#L1430
   
   This comment applies to this entire PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org