[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33780: [SPARK-36540][YARN]YARN-CLIENT mode should check Shutdown message when AMEndpoint disconencted

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #33780:
URL: https://github.com/apache/spark/pull/33780#discussion_r699136313



##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
##########
@@ -793,6 +796,8 @@ private[spark] class ApplicationMaster(
     override def receive: PartialFunction[Any, Unit] = {
       case UpdateDelegationTokens(tokens) =>
         SparkHadoopUtil.get.addDelegationTokens(tokens, sparkConf)
+
+      case Shutdown => shutdown = true

Review comment:
       @tgravescs  move Shutdown to `receive` since it's a OneWayMessage.
   
   And have tested this pr  in  our prod by use gdb to close socket between driver and am.
   The behavior is as expected.

##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
##########
@@ -793,6 +796,8 @@ private[spark] class ApplicationMaster(
     override def receive: PartialFunction[Any, Unit] = {
       case UpdateDelegationTokens(tokens) =>
         SparkHadoopUtil.get.addDelegationTokens(tokens, sparkConf)
+
+      case Shutdown => shutdown = true

Review comment:
       FYI @tgravescs  move Shutdown to `receive` since it's a OneWayMessage.
   
   And have tested this pr  in  our prod by use gdb to close socket between driver and am.
   The behavior is as expected.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org