You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/16 16:19:47 UTC

[GitHub] [fineract] Yann-J commented on pull request #1623: feat: Helm chart

Yann-J commented on pull request #1623:
URL: https://github.com/apache/fineract/pull/1623#issuecomment-800404924


   OK, I've made an update that addresses most comments above (I think), in particular avoid setting default passwords, and raising an error if they're empty.
   
   Some tuning along the way, in particular all extra variables (Secret or not) are now evaluated as templates - don't know if that's useful here but it doesn't hurt, and I've seen many cases where it is. They're also all supporting multiline values. Again, not sure if it's super useful here but you never know.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org