You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "vkagamlyk (via GitHub)" <gi...@apache.org> on 2023/10/30 23:31:35 UTC
[PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
vkagamlyk opened a new pull request, #2315:
URL: https://github.com/apache/tinkerpop/pull/2315
For some integer operations the result is not checked for overflow, which can lead to unexpected results.
For example
```
gremlin> __.inject(Long.MAX_VALUE,Long.MAX_VALUE,2).sum()
==>0
```
In this PR I added throwing `ArithmeticException` for overflow cases.
More details in https://issues.apache.org/jira/browse/TINKERPOP-2877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk closed pull request #2315: [TINKERPOP-2877] Added integer overflow checks
URL: https://github.com/apache/tinkerpop/pull/2315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2315:
URL: https://github.com/apache/tinkerpop/pull/2315#issuecomment-1786216948
We're currently processing your upload. This comment will be updated when the results are available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2315:
URL: https://github.com/apache/tinkerpop/pull/2315#issuecomment-1811613204
It's breaking change, so will go to new major release.
New PR: https://github.com/apache/tinkerpop/pull/2344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2315:
URL: https://github.com/apache/tinkerpop/pull/2315#issuecomment-1787608610
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org