[GitHub] spark pull request #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory...

[kiszk <gi...@git.apache.org>]

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21968#discussion_r212569048
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ---
    @@ -164,9 +164,8 @@ private[joins] class UnsafeHashedRelation(
       def getValue(key: InternalRow): InternalRow = {
         val unsafeKey = key.asInstanceOf[UnsafeRow]
         val map = binaryMap  // avoid the compiler error
    -    val loc = new map.Location  // this could be allocated in stack
    -    binaryMap.safeLookup(unsafeKey.getBaseObject, unsafeKey.getBaseOffset,
    -      unsafeKey.getSizeInBytes, loc, unsafeKey.hashCode())
    +    val loc = map.lookup(unsafeKey.getBaseObject, unsafeKey.getBaseOffset,
    --- End diff --
    
    IIUC, this change makes this part thread-unsafe. Is it OK?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org