[jira] [Commented] (HBASE-14082) Add replica id to JMX metrics names

["Lei Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627396#comment-14627396 ] 

Lei Chen commented on HBASE-14082:
----------------------------------

If the changes are
# adding a getter, getReplicaId(), to MetricsRegionWrapper.java
# inserting a string, "_replicaid_" + regionWrapper.getReplicaId(), to MetricsRegionSourceImpl.java

Should I include a test case? 
I'm not sure if it is preferred that every change should be covered by unit tests.

> Add replica id to JMX metrics names
> -----------------------------------
>
>                 Key: HBASE-14082
>                 URL: https://issues.apache.org/jira/browse/HBASE-14082
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Lei Chen
>            Assignee: Lei Chen
>
> Today, via JMX, one cannot distinguish a primary region from a replica. A possible solution is to add replica id to JMX metrics names. The benefits may include, for example:
> # Knowing the latency of a read request on a replica region means the first attempt to the primary region has timeout.
> # Write requests on replicas are due to the replication process, while the ones on primary are from clients.
> # In case of looking for hot spots of read operations, replicas should be excluded since TIMELINE reads are sent to all replicas.
> To implement, we can change the format of metrics names found at {code}Hadoop->HBase->RegionServer->Regions->Attributes{code}
> from 
> {code}namespace_<namespace>_table_<tablename>_region_<regionname>_metric_<metricname>{code}
> to
> {code}namespace_<namespace>_table_<tablename>_region_<regionname>_replicaid_<replicaid>_metric_<metricname>{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)