[I] [Studio][Bug] STUDIO_AI_RMQCTL_ENABLED cannot disable hosted agent tools [rocketmq-dashboard]

["Aias00 (via GitHub)" <gi...@apache.org>]

Aias00 opened a new issue, #4977:
URL: https://github.com/apache/rocketmq-dashboard/issues/4977

   ## Problem
   
   RocketMQ Studio documents `STUDIO_AI_RMQCTL_ENABLED=false` as the deployment switch that disables hosted `rmqctl` tools and degrades AI conversations to plain chat. `deploy/docker-compose.yml` forwards the variable and `.env.example` exposes it, but `server/src/main/resources/application.yml` hardcodes:
   
   ```yaml
   studio:
     ai:
       conversation:
         rmqctl-enabled: true
   ```
   
   As a result, the forwarded environment variable is ignored. Operators cannot enforce the documented tool-disable policy through the supplied Compose deployment.
   
   ## Proposed design
   
   1. Bind `rmqctl-enabled` to `${STUDIO_AI_RMQCTL_ENABLED:true}` in `application.yml`.
   2. Preserve `true` as the default for deployments that do not set the variable.
   3. Add a focused configuration test that loads the real application config and verifies both the environment override and default.
   4. Leave runtime consumers unchanged; `RmqctlWorkspace` and `AgentCapabilityProbe` already use `AiConversationProperties.isRmqctlEnabled()` correctly.
   
   ## Test plan
   
   - Confirm the override test fails against the current hardcoded YAML.
   - Verify `STUDIO_AI_RMQCTL_ENABLED=false` binds `AiConversationProperties.rmqctlEnabled` to false.
   - Verify the property remains true without an override.
   - Run focused configuration/workspace/capability tests, the AI backend suite, Checkstyle, and package build.
   
   ## Acceptance criteria
   
   - The supplied Compose variable can disable hosted rmqctl tooling.
   - Disabled tooling degrades through the existing plain-chat path.
   - Existing deployments retain the enabled-by-default behavior.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Bug] STUDIO_AI_RMQCTL_ENABLED cannot disable hosted agent tools [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed issue #4977: [Studio][Bug] STUDIO_AI_RMQCTL_ENABLED cannot disable hosted agent tools
URL: https://github.com/apache/rocketmq-dashboard/issues/4977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Bug] STUDIO_AI_RMQCTL_ENABLED cannot disable hosted agent tools [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins commented on issue #4977:
URL: https://github.com/apache/rocketmq-dashboard/issues/4977#issuecomment-5845372687

   Fixed in 04feafe49 (#4978) on the `rocketmq-studio` branch.
   
   Closing manually: GitHub only auto-closes an issue when the pull request is merged into the repository's default branch, and `rocketmq-studio` is not it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org