[GitHub] [pulsar-helm-chart] svabra commented on a diff in pull request #249: Expose pulsar manager backend port

["svabra (via GitHub)" <gi...@apache.org>]

svabra commented on code in PR #249:
URL: https://github.com/apache/pulsar-helm-chart/pull/249#discussion_r1125734154


##########
charts/pulsar/templates/pulsar-manager-service.yaml:
##########
@@ -21,7 +21,7 @@
 apiVersion: v1
 kind: Service
 metadata:
-  name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}"
+  name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}-frontend"

Review Comment:
   @michaeljmarshall Hi, Michael, I fail to understand why this is a breaking change. It's an extension, not a change (apropos open-close-principle). If there is a reason why this would break, what else do you suggest we could submit in the next PR? Any strategy from the team?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org