You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/15 16:42:07 UTC

[GitHub] [geode-native] echobravopapa commented on a change in pull request #674: GEODE-8157: Add DropProxy acceptance test for .NET

echobravopapa commented on a change in pull request #674:
URL: https://github.com/apache/geode-native/pull/674#discussion_r505687688



##########
File path: clicache/acceptance-test/SNITests.cs
##########
@@ -127,5 +133,38 @@ public void ConnectionWithoutProxyFails()
 
             Assert.Throws<NotConnectedException>(() => region.Put("1", "one"));
         }
+

Review comment:
       It would be great to have this test:
   - bring up the system/cluster
   - do a cache ops (put/get)
   - drop the proxy
   - attempt cache ops - wait for exception (EXPECTEXCEPTION in gtest or similar...)
   - bring proxy back up
   - then do verify cache ops (put/get)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org