You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2022/06/08 08:13:48 UTC
[spark] branch master updated: [SPARK-39321][SQL][TESTS][FOLLOW-UP] Respect CastWithAnsiOffSuite.ansiEnabled in 'cast string to date #2'
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 25f38b12c06 [SPARK-39321][SQL][TESTS][FOLLOW-UP] Respect CastWithAnsiOffSuite.ansiEnabled in 'cast string to date #2'
25f38b12c06 is described below
commit 25f38b12c06daa108f2367e5244a5053e281df21
Author: Hyukjin Kwon <gu...@apache.org>
AuthorDate: Wed Jun 8 17:13:35 2022 +0900
[SPARK-39321][SQL][TESTS][FOLLOW-UP] Respect CastWithAnsiOffSuite.ansiEnabled in 'cast string to date #2'
### What changes were proposed in this pull request?
This PR fixes the test to make `CastWithAnsiOffSuite` properly respect `ansiEnabled` in `cast string to date #2` test by using `CastWithAnsiOffSuite.cast` instead of `Cast` expression.
### Why are the changes needed?
To make the tests pass. Currently it fails when ANSI mode is on:
https://github.com/apache/spark/runs/6786744647
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
Manually tested in my IDE.
Closes #36802 from HyukjinKwon/SPARK-39321-followup.
Authored-by: Hyukjin Kwon <gu...@apache.org>
Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
.../spark/sql/catalyst/expressions/CastWithAnsiOffSuite.scala | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOffSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOffSuite.scala
index 4e4bc096dea..56e586da2a3 100644
--- a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOffSuite.scala
+++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOffSuite.scala
@@ -65,11 +65,11 @@ class CastWithAnsiOffSuite extends CastSuiteBase {
}
test("cast string to date #2") {
- checkEvaluation(Cast(Literal("2015-03-18X"), DateType), null)
- checkEvaluation(Cast(Literal("2015/03/18"), DateType), null)
- checkEvaluation(Cast(Literal("2015.03.18"), DateType), null)
- checkEvaluation(Cast(Literal("20150318"), DateType), null)
- checkEvaluation(Cast(Literal("2015-031-8"), DateType), null)
+ checkEvaluation(cast(Literal("2015-03-18X"), DateType), null)
+ checkEvaluation(cast(Literal("2015/03/18"), DateType), null)
+ checkEvaluation(cast(Literal("2015.03.18"), DateType), null)
+ checkEvaluation(cast(Literal("20150318"), DateType), null)
+ checkEvaluation(cast(Literal("2015-031-8"), DateType), null)
}
test("casting to fixed-precision decimals") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org