You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/13 21:31:00 UTC

[jira] [Work logged] (GOBBLIN-1664) Allow table to flush after write failure

     [ https://issues.apache.org/jira/browse/GOBBLIN-1664?focusedWorklogId=780938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780938 ]

ASF GitHub Bot logged work on GOBBLIN-1664:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jun/22 21:30
            Start Date: 13/Jun/22 21:30
    Worklog Time Spent: 10m 
      Work Description: jack-moseley opened a new pull request, #3522:
URL: https://github.com/apache/gobblin/pull/3522

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1664
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
   Currently if a table fails to write, we reset the writer that failed, and also remove it from the `tableOperationTypeMap` to avoid a no-op flush. However, if the writer that failed is not the first writer, there may still be other succeeding writers that we do want to flush. Removing this line so that we will still flush even if there was a failure of a writer for this situation.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Trivial
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 780938)
    Remaining Estimate: 0h
            Time Spent: 10m

> Allow table to flush after write failure
> ----------------------------------------
>
>                 Key: GOBBLIN-1664
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1664
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)