You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/03/27 18:15:06 UTC

[jira] [Commented] (NET-393) Should the sendCommandWithID() methods be public?

    [ https://issues.apache.org/jira/browse/NET-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011817#comment-13011817 ] 

Sebb commented on NET-393:
--------------------------

Note that users can override the protected generateCommandId() method if they wish to change the tag format

> Should the sendCommandWithID() methods be public?
> -------------------------------------------------
>
>                 Key: NET-393
>                 URL: https://issues.apache.org/jira/browse/NET-393
>             Project: Commons Net
>          Issue Type: Sub-task
>            Reporter: Sebb
>            Priority: Minor
>
> Should the sendCommandWithID() methods be public?
> These allow the user to override the tag generation, or even send invalid tags.
> I think it would be better to reserve these for internal use.
> If a use case for them is found later, the visibility can be changed back. 
> But reducing visibility breaks binary compatibility - best to start with minimal visibility (and mutabiliy) and relax as necessary later.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira