You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/06 21:53:29 UTC
[GitHub] [superset] nytai opened a new pull request #12315: feat: provide config to insert html tags on every view
nytai opened a new pull request #12315:
URL: https://github.com/apache/superset/pull/12315
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
- introduces a config to support inserting arbitrary html into every view. This is hooks can be used to add google analytics scrips (or any js snippet) to superset views.
-
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
- provide a js snippet, eg
```
HTML_TEMPLATE_SCRIPT = "<script> console.log('IT WORKS!') </script>"
```
- navigate open superset to any view
- console output should contain message
- html should include the snippet
-
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `0.24%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.24% +0.24%
==========================================
Files 1002 485 -517
Lines 49286 29864 -19422
Branches 5010 0 -5010
==========================================
- Hits 31049 18888 -12161
+ Misses 18035 10976 -7059
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.24% <100.00%> (-0.92%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [540 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (25a8912) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.52%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.52% +0.52%
==========================================
Files 1002 485 -517
Lines 49286 29866 -19420
Branches 5010 0 -5010
==========================================
- Hits 31049 18972 -12077
+ Misses 18035 10894 -7141
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.52% <100.00%> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...25a8912](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (25a8912) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.61% +0.61%
==========================================
Files 1002 485 -517
Lines 49286 29866 -19420
Branches 5010 0 -5010
==========================================
- Hits 31049 18999 -12050
+ Misses 18035 10867 -7168
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.61% <100.00%> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [526 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...25a8912](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `0.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.61% +0.61%
==========================================
Files 1002 485 -517
Lines 49286 29864 -19422
Branches 5010 0 -5010
==========================================
- Hits 31049 18997 -12052
+ Misses 18035 10867 -7168
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.61% <100.00%> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [524 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553618148
##########
File path: superset/views/base.py
##########
@@ -333,6 +342,14 @@ def serialize_bootstrap_data() -> str:
return {"bootstrap_data": serialize_bootstrap_data}
+@superset_app.context_processor
+def get_html_template_script() -> Dict[str, Any]:
+ def process_template_script() -> str:
+ return render_template_string(superset_app.config["HTML_TEMPLATE_SCRIPT"])
Review comment:
unfortunately we're not going with this route (see discussion bellow), though your suggestion would definitely make sense for the current approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755765758
Uh, are we sure this is what we want? It might not be easy to run Google Analytics (or any other tracking scripts) with a single script tag when we migrate everything to an SPA (which I believe is the future direction?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0e31413) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.54% +0.54%
==========================================
Files 1002 485 -517
Lines 49286 29886 -19400
Branches 5010 0 -5010
==========================================
- Hits 31049 18990 -12059
+ Misses 18035 10896 -7139
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.54% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [524 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0e31413](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (be9b8aa) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 62.90% -0.10%
==========================================
Files 1002 1002
Lines 49286 49322 +36
Branches 5010 5020 +10
==========================================
- Hits 31049 31024 -25
- Misses 18035 18094 +59
- Partials 202 204 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.18% <ø> (-0.03%)` | :arrow_down: |
| python | `64.01% <100.00%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `50.52% <0.00%> (-0.01%)` | :arrow_down: |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...be9b8aa](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553597864
##########
File path: superset/views/base.py
##########
@@ -333,6 +342,14 @@ def serialize_bootstrap_data() -> str:
return {"bootstrap_data": serialize_bootstrap_data}
+@superset_app.context_processor
+def get_html_template_script() -> Dict[str, Any]:
+ def process_template_script() -> str:
+ return render_template_string(superset_app.config["HTML_TEMPLATE_SCRIPT"])
Review comment:
This is really cool !
But , should we have parallel support for HTML_STRING and HTML_TEMPLATE_STRING ?
For who does want to use template and can potentially reduce security risk by not enabling template
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sravfeyn commented on pull request #12315: feat: provide support for an overridable template to be included in every view
Posted by GitBox <gi...@apache.org>.
sravfeyn commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-1082880545
As a user, do I have to install my own modified superset package that has a modified `tail_js_custom_extra` with my snippet in it? Is there way I can include extra snippet without overriding the superset package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sravfeyn edited a comment on pull request #12315: feat: provide support for an overridable template to be included in every view
Posted by GitBox <gi...@apache.org>.
sravfeyn edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-1082880545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `0.60%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.60% +0.60%
==========================================
Files 1002 485 -517
Lines 49286 29879 -19407
Branches 5010 0 -5010
==========================================
- Hits 31049 19004 -12045
+ Misses 18035 10875 -7160
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.60% <100.00%> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [517 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553680510
##########
File path: superset/templates/superset/basic.html
##########
@@ -104,5 +104,8 @@ <h4 data-test="modal-title" class="modal-title"></h4>
{{ js_bundle(entry) }}
{% endif %}
{% endblock %}
+ {% block custom_template %}
Review comment:
oh right, this is because we have one template https://github.com/preset-io/incubator-superset/blob/0e31413fa36180a74febe6a17b00072907d3d62d/superset/templates/superset/crud_views.html#L24 that is overriding tail_js without calling super(). I think it has to do with the menu already being included in that "app". I guess we could add the `{% include "tail_js_custom_extra.html" %}` call in there too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755914927
@ktmud, I wanted to point out that if `app.config` is accessible/compromised, the whole app is compromised at that point and the `HTML_TEMPLATE_SCRIPT` would be *at best* a convenient hook to do certain things.
Generally I'm bullish on letting people adding hooks that are unlikely to be used by most especially if we add a note/disclaimer to "use with caution". @nytai maybe you can add a note to that effect in `config.py`. Generally we can trust that administrator should know what they're doing.
I know there are many dom-based tools that are pretty smart about monitoring url history for changes. From the page you linked to above:
_Note: Developers creating Single Page Applications can use autotrack, which includes a urlChangeTracker plugin that handles all of the important considerations listed in this guide for you. See the autotrack documentation for usage and installation instructions_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (8f7c7d4) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
=======================================
Coverage 63.51% 63.51%
=======================================
Files 485 485
Lines 29858 29858
=======================================
Hits 18964 18964
Misses 10894 10894
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `63.51% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `1.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 64.16% +1.17%
==========================================
Files 1002 485 -517
Lines 49286 29879 -19407
Branches 5010 0 -5010
==========================================
- Hits 31049 19173 -11876
+ Misses 18035 10706 -7329
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | | |
| [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | | |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | | |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | | |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | | |
| [superset-frontend/src/components/Hotkeys.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSG90a2V5cy5qc3g=) | | |
| [.../src/views/CRUD/alert/components/RecipientIcon.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9SZWNpcGllbnRJY29uLnRzeA==) | | |
| [...rontend/src/dashboard/containers/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553655432
##########
File path: .gitignore
##########
@@ -87,3 +87,5 @@ release.json
messages.mo
docker/requirements-local.txt
+
+superset/templates/custom_override_template.html
Review comment:
```
The file is tracked, but future changes to the file are not.
```
This is not true. Once a file is tracked, any changes you made would show up in `git status` and will be committed if you do `git commit -a` (even without `-f`).
`tail_js_custom_extra` sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553672893
##########
File path: .gitignore
##########
@@ -87,3 +87,5 @@ release.json
messages.mo
docker/requirements-local.txt
+
+superset/templates/custom_override_template.html
Review comment:
Ah, you are correct. You can ignore entire directories, except for one file, by adding the dir to `.gitignore` then adding the file with with `git add -f ...`. I assumed it worked similarly for files and subsequent changes 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553639022
##########
File path: .gitignore
##########
@@ -87,3 +87,5 @@ release.json
messages.mo
docker/requirements-local.txt
+
+superset/templates/custom_override_template.html
Review comment:
I don't think `.gitignore` is needed if the file is tracked anyway. You could either:
1. Remove this file from `.gitignore`
2. Add it to `.gitignore` but delete the example file.
The name `custom_override_template` also sounds kind of generic (people may expect it to override the whole page). How about `tail_js_extra.html`?
```jinja
{% block tail_js %}
{{ super() }}
{{ js_bundle("preamble") }}
{{ js_bundle('menu') }}
{#
This file may be overriden in your custom deployment.
It will be included in every view in superset and is a
good place to include your custom frontend code, such as
scripts to initialize google analytics, intercom, segment, etc.
#}
{% include "tail_js_extra.html" ignore missing %}
{% endblock %}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
=======================================
Coverage 62.99% 63.00%
=======================================
Files 1002 1002
Lines 49286 49292 +6
Branches 5010 5010
=======================================
+ Hits 31049 31057 +8
+ Misses 18035 18033 -2
Partials 202 202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.21% <ø> (+0.01%)` | :arrow_up: |
| python | `64.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `59.23% <0.00%> (+0.63%)` | :arrow_up: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `83.54% <0.00%> (+1.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (dba26bf) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.44%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.43% +0.44%
==========================================
Files 1002 485 -517
Lines 49286 29886 -19400
Branches 5010 0 -5010
==========================================
- Hits 31049 18959 -12090
+ Misses 18035 10927 -7108
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.43% <ø> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [532 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...dba26bf](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756322433
Someone with access to `app.config` gets access to the `os` module as well as the pointer to the `static` and `uploads` folder - copying the contents of `static` to `uploads`, pointing `static` at `uploads` and making alterations would result in the ability to write arbitrary data to the front end from any file. We are not adding an additional vulnerability with this change. QED `app.config` compromise is a full compromise of the web application.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553652107
##########
File path: .gitignore
##########
@@ -87,3 +87,5 @@ release.json
messages.mo
docker/requirements-local.txt
+
+superset/templates/custom_override_template.html
Review comment:
The idea with adding the gitignore entry was so that
1. There is an example file
2. The file is tracked, but future changes to the file are not. This allows users to add changes to the file without needing to commit those changes or manage that diff.
3. Changes can be committed via `git add -f superset/templates/custom_override_template.html` if necessary.
Though I see how this is could likely become source of confusion for those unfamiliar with this pattern. I'll remove the gitignore entry.
How does `tail_js_custom_extra.html` sound? To me`tail_js_extra.html` sounds like an internal name and not really like a vector for customization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (8f7c7d4) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
=======================================
Coverage 64.11% 64.11%
=======================================
Files 485 485
Lines 29873 29873
=======================================
Hits 19152 19152
Misses 10721 10721
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `64.11% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
nytai edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755787917
@ktmud When we do eventually move to a single page app we can just do a `document.insertAdjacentHTML('beforeEnd', HTML_TEMPLATE_SCRIPT)` as part of the app initialization step in the preamble https://github.com/apache/superset/blob/8f7c7d43a3cfc71e5a58bbe317f65626f839f830/superset-frontend/src/preamble.ts#L32
Or we can keep the current logic in the template we do end up using for all our views (assuming we haven't completely moved off flask/jinja by then)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755848477
We still have a number of jinja templates and no current plans to remove them. Theres a strong case for having this tag fire on those pages as well. These tracking scripts are usually pretty good at detecting page transitions even if they’re only changes to history and not actual page reloads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756416385
I'd rather we not continue this security discussion as I think we can all agree that an attacker gaining access to app.config is pretty much a doomsday scenario given that the secret key and database passwords are stored in that config. Also If an attacker has write access to app.config they've likely gained access to the entire server environment and pretty much everything (BE or FE) would be compromised at that point.
I don't see any difference wdt security if the template lives in the config file as a string or a seperate jinja template file, but you are right it is a slightly nicer api to be editing a template files instead of a string. I'll make these changes shortly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (dba26bf) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `4.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 58.90% -4.10%
==========================================
Files 1002 949 -53
Lines 49286 46722 -2564
Branches 5010 4329 -681
==========================================
- Hits 31049 27520 -3529
- Misses 18035 19202 +1167
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.84% <ø> (?)` | |
| javascript | `?` | |
| python | `63.43% <ø> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| ... and [456 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...dba26bf](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (8f7c7d4) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
=======================================
Coverage 63.95% 63.95%
=======================================
Files 485 485
Lines 29873 29873
=======================================
Hits 19106 19106
Misses 10767 10767
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `63.95% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `1.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 64.16% +1.17%
==========================================
Files 1002 485 -517
Lines 49286 29879 -19407
Branches 5010 0 -5010
==========================================
- Hits 31049 19173 -11876
+ Misses 18035 10706 -7329
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [...set-frontend/src/common/components/ProgressBar.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Byb2dyZXNzQmFyLnRzeA==) | | |
| [...rset-frontend/src/components/AsyncEsmComponent.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNFc21Db21wb25lbnQudHN4) | | |
| [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | | |
| [superset-frontend/src/setup/setupPluginsExtra.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLnRz) | | |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | | |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | | |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756318188
> I disagree with the concerns raised about security, a compromise of app.config is a full pwn in any way we slice it.
Maybe I wasn't clear. It is true that a comprised `app.config` is very serious, but that only means attackers will have access to db credentials and access to datasources **Superset** can connect to---it doesn't mean attackers can access **other internal systems** via **any user's credentials** that are possibly behind an VPN. When you add the ability to write **arbitrary** content to the HTML page, it opens a whole new flood gate. I'll admit such attack is rare, but it doesn't seem worth the risk if we do have another feasible path for the business needs in question.
> I don't think replacing a file before building the frontend will work for our use case given that we're relying on the render_template_string to populate a few values in the script (eg, current_user.id).
You can easily add such info to the bootstrap data. In fact, in a full backend-frontend separated architecture, you would want to add that info to the bootstrap data.
Finally, even if we want to implement this in Jinja template, we can add a blank overridable template file that is not tracked by Git. Then use Jinja's `include ignore missing`:
```jinja
{%include "footer_extra.html" ignore missing %}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (dba26bf) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.43%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.43% +0.43%
==========================================
Files 1002 485 -517
Lines 49286 29884 -19402
Branches 5010 0 -5010
==========================================
- Hits 31049 18957 -12092
+ Misses 18035 10927 -7108
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.43% <ø> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...dba26bf](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755849137
Also, I suspect even if we do do manage to get the app down to a single bundle, flask will still be serving the app and assets bundle through a (single) jinja temple file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (8f7c7d4) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
=======================================
Coverage 63.92% 63.92%
=======================================
Files 485 485
Lines 29873 29873
=======================================
Hits 19097 19097
Misses 10776 10776
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `63.92% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on a change in pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553495856
##########
File path: superset/config.py
##########
@@ -733,6 +733,10 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
CONFIG_PATH_ENV_VAR = "SUPERSET_CONFIG_PATH"
+# vVlid html code that will be injected into every view.
Review comment:
Nit: Valid
Let's add a disclaimer here about only adding trusted code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (25a8912) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 62.89% -0.11%
==========================================
Files 1002 1002
Lines 49286 49322 +36
Branches 5010 5020 +10
==========================================
- Hits 31049 31022 -27
- Misses 18035 18096 +61
- Partials 202 204 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.17% <ø> (-0.04%)` | :arrow_down: |
| python | `64.01% <100.00%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `50.52% <0.00%> (-0.01%)` | :arrow_down: |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...25a8912](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756364106
> Someone with access to app.config gets access to the os module
I'm not sure this is true... Could you point me to where the leakage might be?
Either way, wdyt of the jinja template override approach? You don't have to render the config value separately and you get syntax highlighting for free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0e31413) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `1.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 64.04% +1.04%
==========================================
Files 1002 485 -517
Lines 49286 29886 -19400
Branches 5010 0 -5010
==========================================
- Hits 31049 19140 -11909
+ Misses 18035 10746 -7289
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.04% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | | |
| [superset-frontend/src/components/ListView/index.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvaW5kZXgudHM=) | | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | | |
| [...perset-frontend/src/utils/getControlsForVizType.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENvbnRyb2xzRm9yVml6VHlwZS5qcw==) | | |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0e31413](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (f169112) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `3.64%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 59.34% -3.65%
==========================================
Files 1002 951 -51
Lines 49286 46664 -2622
Branches 5010 4312 -698
==========================================
- Hits 31049 27695 -3354
- Misses 18035 18969 +934
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.44% <ø> (?)` | |
| javascript | `?` | |
| python | `63.79% <100.00%> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [438 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553656316
##########
File path: superset/templates/superset/basic.html
##########
@@ -104,5 +104,8 @@ <h4 data-test="modal-title" class="modal-title"></h4>
{{ js_bundle(entry) }}
{% endif %}
{% endblock %}
+ {% block custom_template %}
Review comment:
Can we move the `include` into `block tail_js` like in `base.html`? I'm not sure why these two files are handled differently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756318188
> I disagree with the concerns raised about security, a compromise of app.config is a full pwn in any way we slice it.
Maybe I wasn't clear. It is true that a comprised `app.config` is very serious, but that only means attackers will have access to db credentials and access to datasources **Superset** can connect to---it doesn't mean attackers can access **other internal systems** via **any user's credentials** that are possibly behind an VPN. When you add the ability to write **arbitrary** content to the HTML page, it opens a whole new flood gate. I'll admit such attack is rare, but it doesn't seem worth the risk if we do have another feasible path for the business needs in question.
> I don't think replacing a file before building the frontend will work for our use case given that we're relying on the render_template_string to populate a few values in the script (eg, current_user.id).
You can easily add such info to the bootstrap data. In fact, in a full backend-frontend separated architecture, you would want to add that info to the bootstrap data.
Finally, even if we want to implement this in Jinja template, you can also add a blank overridable template file or use Jinja's `include ignore missing`:
```jinja
{%include "footer_extra.html" ignore missing %}
```
This way you also get syntax highlighting for free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (25a8912) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 62.99% -0.01%
==========================================
Files 1002 1002
Lines 49286 49322 +36
Branches 5010 5020 +10
==========================================
+ Hits 31049 31068 +19
- Misses 18035 18050 +15
- Partials 202 204 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.17% <ø> (-0.04%)` | :arrow_down: |
| python | `64.17% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `50.52% <0.00%> (-0.01%)` | :arrow_down: |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (ø)` | |
| [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | `88.29% <0.00%> (+0.12%)` | :arrow_up: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `46.79% <0.00%> (+0.14%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...25a8912](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0736278) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `0.40%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 62.59% -0.41%
==========================================
Files 1002 1001 -1
Lines 49286 49367 +81
Branches 5010 5033 +23
==========================================
- Hits 31049 30899 -150
- Misses 18035 18261 +226
- Partials 202 207 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.99% <ø> (-0.22%)` | :arrow_down: |
| python | `63.63% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Hotkeys.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSG90a2V5cy5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `58.97% <0.00%> (-41.03%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SaveQuery.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS50c3g=) | `72.72% <0.00%> (-15.37%)` | :arrow_down: |
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | `71.42% <0.00%> (-14.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `66.66% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0736278](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755936639
@mistercrunch The library you mentioned had a disclaimer [on there GitHub page ](https://github.com/googleanalytics/autotrac) saying it is no longer actively maintained.
And I believe it is deprecated for a reason: the DOM-based approach is unreliable and not scalable. Hook tracking into native browser events without letting the app itself know sounds monkey-patchy and could easily break. You never know how it will interact with app code (or library code that you have no control of).
It may work well for getting quick stats from simpler apps, but could quickly fall short of usefulness in a complex app like Superset. A proper way to do this is to provide a generalized interface for client-side tracking, plant the track code in proper places, and let administrators/developers decide where the events are sent to.
If all we want is to have a quick way of injecting GA scripts, we could just introduce a `preambleExtra.ts` override file. This way,
1. We don't have to worry about the additional risk of arbitrary content in the HTML.
2. The tracking code can still have access to ESM modules (hence Superset app context) if needed, which in general is not possible with script tags.
As regards to the security risks, I am no expert in this area, but I'd imagine the security risks between having access to `app.config` vs having the ability to inject arbitrary HTML code to the end users are still different. The attackers could do a lot of nasty stuff via the browser----e.g. making a request to an internal URL that only an authorized user in the browser has access to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553656316
##########
File path: superset/templates/superset/basic.html
##########
@@ -104,5 +104,8 @@ <h4 data-test="modal-title" class="modal-title"></h4>
{{ js_bundle(entry) }}
{% endif %}
{% endblock %}
+ {% block custom_template %}
Review comment:
Can we just move the `include` into `block tail_js` like in `base.html`? I'm not sure why this file needs a new block but the other one does not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (8f7c7d4) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
=======================================
Coverage 63.50% 63.50%
=======================================
Files 485 485
Lines 29873 29873
=======================================
Hits 18971 18971
Misses 10902 10902
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `63.50% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (dba26bf) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `3.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 59.03% -3.96%
==========================================
Files 1002 949 -53
Lines 49286 46722 -2564
Branches 5010 4329 -681
==========================================
- Hits 31049 27584 -3465
- Misses 18035 19138 +1103
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.22% <ø> (?)` | |
| javascript | `?` | |
| python | `63.43% <ø> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| ... and [456 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...dba26bf](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (8f7c7d4) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
=======================================
Coverage 62.99% 62.99%
=======================================
Files 1002 1002
Lines 49286 49286
Branches 5010 5010
=======================================
Hits 31049 31049
Misses 18035 18035
Partials 202 202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.20% <0.00%> (ø)` | |
| python | `64.16% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0736278) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.63% +0.63%
==========================================
Files 1002 485 -517
Lines 49286 29886 -19400
Branches 5010 0 -5010
==========================================
- Hits 31049 19017 -12032
+ Misses 18035 10869 -7166
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.63% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <0.00%> (ø)` | |
| [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| ... and [518 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0736278](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (be9b8aa) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.56%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.56% +0.56%
==========================================
Files 1002 485 -517
Lines 49286 29866 -19420
Branches 5010 0 -5010
==========================================
- Hits 31049 18983 -12066
+ Misses 18035 10883 -7152
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.56% <100.00%> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...be9b8aa](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (f169112) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.79%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.79% +0.79%
==========================================
Files 1002 485 -517
Lines 49286 29879 -19407
Branches 5010 0 -5010
==========================================
- Hits 31049 19060 -11989
+ Misses 18035 10819 -7216
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.79% <100.00%> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [517 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0736278) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.58% +0.58%
==========================================
Files 1002 485 -517
Lines 49286 29871 -19415
Branches 5010 0 -5010
==========================================
- Hits 31049 18994 -12055
+ Misses 18035 10877 -7158
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.58% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [527 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0736278](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
nytai edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755787917
@ktmud When we do eventually move to a single page app we can just do a `document.insertAdjacentHTML('beforeEnd', HTML_TEMPLATE_SCRIPT)` as part of the app initialization step in the preamble https://github.com/apache/superset/blob/8f7c7d43a3cfc71e5a58bbe317f65626f839f830/superset-frontend/src/preamble.ts#L32
Or we can keep the current logic in the template we do end up using for all our views (assuming we haven't completely moved off flask/jinja)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
nytai edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756295935
@ktmud superset currently has an events tracking system where events are relayed to a backend system, which can then relayed to a generic events tracking system. My example of google analytics was probably not the best. Full context, we will be using this config to add [pendo](https://support.pendo.io/hc/en-us/articles/360031862272-Installation-for-Single-Page-Frameworkshttps://support.pendo.io/hc/en-us/articles/360031862272-Installation-for-Single-Page-Frameworks) which mentions not needing any special config for single-page apps. Something like [intercom](https://www.intercom.com/) or [fullstory](https://www.fullstory.com/) would work similarly.
I don't think replacing a file before building the frontend will work for our use case given that we're relying on the `render_template_string` to populate a few values in the script (eg, current_user.id).
re: security, I'll add the disclaimer to the config file. This does open up a potential attack vector, however there are many other ways in which people configuring superset can shoot themselves in the foot. In general people configuring and deploying and app should be aware of what they're doing, especially in prod-like environments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0e31413) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.63% +0.63%
==========================================
Files 1002 485 -517
Lines 49286 29886 -19400
Branches 5010 0 -5010
==========================================
- Hits 31049 19017 -12032
+ Misses 18035 10869 -7166
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.63% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | | |
| ... and [518 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0e31413](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (f169112) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.52%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.52% +0.52%
==========================================
Files 1002 485 -517
Lines 49286 29864 -19422
Branches 5010 0 -5010
==========================================
- Hits 31049 18970 -12079
+ Misses 18035 10894 -7141
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.52% <100.00%> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553027183
##########
File path: superset/views/base.py
##########
@@ -333,6 +342,14 @@ def serialize_bootstrap_data() -> str:
return {"bootstrap_data": serialize_bootstrap_data}
+@superset_app.context_processor
+def get_html_template_script() -> Dict[str, Any]:
+ def process_template_script() -> str:
+ return render_template_string(superset_app.config["HTML_TEMPLATE_SCRIPT"])
Review comment:
call render_template_string incase HTML_TEMPLATE_STRING contains template variables
##########
File path: superset/views/base.py
##########
@@ -333,6 +342,14 @@ def serialize_bootstrap_data() -> str:
return {"bootstrap_data": serialize_bootstrap_data}
+@superset_app.context_processor
+def get_html_template_script() -> Dict[str, Any]:
+ def process_template_script() -> str:
+ return render_template_string(superset_app.config["HTML_TEMPLATE_SCRIPT"])
Review comment:
call render_template_string incase `HTML_TEMPLATE_STRING` contains template variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (25a8912) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.60%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.60% +0.60%
==========================================
Files 1002 485 -517
Lines 49286 29881 -19405
Branches 5010 0 -5010
==========================================
- Hits 31049 19006 -12043
+ Misses 18035 10875 -7160
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.60% <100.00%> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...25a8912](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ypankovych commented on pull request #12315: feat: provide support for an overridable template to be included in every view
Posted by GitBox <gi...@apache.org>.
ypankovych commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-947622466
that's what we did:
```python
from superset import manifest_processor
from superset.extensions import UIManifestProcessor
def extend_ui_manifest():
"""
Makes our custom JS files to be executed on every HTML page.
In order to add JS file, go to `/static/assets/dist/manifest.json`
and add path to JS file within the `/static` folder, e.g:
>>> {
>>> "js": [
>>> "welcome/walkme.js",
>>> "hello.js",
>>> ]
>>> }
"""
with open(os.path.join(SIMPLESET_STATIC_DIR, "assets", "dist", "manifest.json")) as fp:
manifest = json.load(fp)
parse_manifest_json = UIManifestProcessor.parse_manifest_json
def custom_parse_manifest_json(self):
parse_manifest_json(self)
entrypoints = self.manifest.setdefault("theme", {"js": []})["js"]
for js_path in manifest["js"]:
# /static handled by our custom static view
entrypoints.append(os.path.join("/static", js_path))
UIManifestProcessor.parse_manifest_json = custom_parse_manifest_json
manifest_processor.parse_manifest_json()
```
But in order for this to work, you also need to patch superset static, e.g:
```python
def flask_app_mutator(app):
def superset_static(self, filename): # vendored from flask and modified to support our static files
if not self.has_static_folder and not self.config.get("SUPERSET_STATIC"):
raise RuntimeError("No static folder for this object")
# Ensure get_send_file_max_age is called in all cases.
# Here, we ensure get_send_file_max_age is called for Blueprints.
cache_timeout = self.get_send_file_max_age(filename)
for static_folder in filter(None, (self.config.get("SUPERSET_STATIC"), self.static_folder)):
with contextlib.suppress(NotFound):
return send_from_directory(
static_folder, filename, cache_timeout=cache_timeout
)
raise NotFound
extend_ui_manifest()
app.view_functions["static"] = MethodType(superset_static, app) # hack
```
And then you simply edit that manifest from our static folder:
```json
{
"js": [
"walkme.js",
"a/b/c/hello.js"
]
}
```
Above JS files will be loaded along with `base.html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (25a8912) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.57%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.57% +0.57%
==========================================
Files 1002 485 -517
Lines 49286 29866 -19420
Branches 5010 0 -5010
==========================================
- Hits 31049 18987 -12062
+ Misses 18035 10879 -7156
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.57% <100.00%> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [529 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...25a8912](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (be9b8aa) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 62.98% -0.01%
==========================================
Files 1002 1002
Lines 49286 49322 +36
Branches 5010 5020 +10
==========================================
+ Hits 31049 31067 +18
- Misses 18035 18051 +16
- Partials 202 204 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.18% <ø> (-0.03%)` | :arrow_down: |
| python | `64.16% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `50.52% <0.00%> (-0.01%)` | :arrow_down: |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (ø)` | |
| [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | `88.29% <0.00%> (+0.12%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...be9b8aa](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `1.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 64.01% +1.01%
==========================================
Files 1002 485 -517
Lines 49286 29879 -19407
Branches 5010 0 -5010
==========================================
- Hits 31049 19127 -11922
+ Misses 18035 10752 -7283
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.01% <100.00%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | | |
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | | |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | | |
| ... and [514 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755886850
You may override `preamble.ts` or add a `preambleExtra.ts` for FAB pages. I believe it is included in every page we currently have.
At least for Google Analytics, [you have to](https://developers.google.com/analytics/devguides/collection/analyticsjs/single-page-applications) manually send pageview tracking requests for SPAs:
And it has its own complexity.
I just find it hacky to allow Superset admins to inject arbitrary HTML/JS tags to the page. It could have security risks as well. Imagine if an attacker got access to `app.config` via a Flask vulnerability, they could basically inject any content to a Superset page, where as it would be more difficult to do so if the overrides are done at the file system level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `0.57%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.57% +0.57%
==========================================
Files 1002 485 -517
Lines 49286 29864 -19422
Branches 5010 0 -5010
==========================================
- Hits 31049 18985 -12064
+ Misses 18035 10879 -7156
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.57% <100.00%> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [527 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai merged pull request #12315: feat: provide support for an overridable template to be included in every view
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #12315:
URL: https://github.com/apache/superset/pull/12315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (f169112) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `3.80%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 59.18% -3.81%
==========================================
Files 1002 951 -51
Lines 49286 46664 -2622
Branches 5010 4312 -698
==========================================
- Hits 31049 27620 -3429
- Misses 18035 19044 +1009
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.99% <ø> (?)` | |
| javascript | `?` | |
| python | `63.79% <100.00%> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [438 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553597864
##########
File path: superset/views/base.py
##########
@@ -333,6 +342,14 @@ def serialize_bootstrap_data() -> str:
return {"bootstrap_data": serialize_bootstrap_data}
+@superset_app.context_processor
+def get_html_template_script() -> Dict[str, Any]:
+ def process_template_script() -> str:
+ return render_template_string(superset_app.config["HTML_TEMPLATE_SCRIPT"])
Review comment:
This is really cool !
But , shouldn't we have parallel support for HTML_STRING and HTML_TEMPLATE_STRING ?
For who does want to use template and can potentially reduce security risk by not enabling template
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (be9b8aa) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.25%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.24% +0.25%
==========================================
Files 1002 485 -517
Lines 49286 29866 -19420
Branches 5010 0 -5010
==========================================
- Hits 31049 18890 -12159
+ Misses 18035 10976 -7059
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.24% <100.00%> (-0.92%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [542 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...be9b8aa](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (80fbbe4) into [master](https://codecov.io/gh/apache/superset/commit/0e514c184c438689580b7d1563d28951ed7b0f47?el=desc) (0e514c1) will **increase** coverage by `1.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 64.16% +1.17%
==========================================
Files 1002 485 -517
Lines 49286 29879 -19407
Branches 5010 0 -5010
==========================================
- Hits 31049 19173 -11876
+ Misses 18035 10706 -7329
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [...ashboard/components/gridComponents/new/NewTabs.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdUYWJzLmpzeA==) | | |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | | |
| [superset-frontend/src/SqlLab/constants.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb25zdGFudHMudHM=) | | |
| [...nd/src/messageToasts/containers/ToastPresenter.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29udGFpbmVycy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
| [superset-frontend/src/api/dataset.ts](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FwaS9kYXRhc2V0LnRz) | | |
| [...end/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS90cmFuc2Zvcm1Qcm9wcy5qcw==) | | |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | |
| [...hboard/components/gridComponents/new/NewColumn.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdDb2x1bW4uanN4) | | |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [0e514c1...80fbbe4](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0736278) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.57% +0.58%
==========================================
Files 1002 485 -517
Lines 49286 29886 -19400
Branches 5010 0 -5010
==========================================
- Hits 31049 19001 -12048
+ Misses 18035 10885 -7150
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.57% <ø> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0736278](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756428264
@ktmud how do the latest changes look? I'll update the PR description shortly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0e31413) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 62.93% -0.07%
==========================================
Files 1002 1001 -1
Lines 49286 49367 +81
Branches 5010 5033 +23
==========================================
+ Hits 31049 31068 +19
- Misses 18035 18092 +57
- Partials 202 207 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.99% <ø> (-0.22%)` | :arrow_down: |
| python | `64.19% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Hotkeys.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSG90a2V5cy5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `58.97% <0.00%> (-41.03%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SaveQuery.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS50c3g=) | `72.72% <0.00%> (-15.37%)` | :arrow_down: |
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | `71.42% <0.00%> (-14.29%)` | :arrow_down: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `66.66% <0.00%> (-3.71%)` | :arrow_down: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `47.61% <0.00%> (-2.39%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.01% <0.00%> (-0.88%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `92.68% <0.00%> (-0.87%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `67.56% <0.00%> (-0.62%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0e31413](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553652107
##########
File path: .gitignore
##########
@@ -87,3 +87,5 @@ release.json
messages.mo
docker/requirements-local.txt
+
+superset/templates/custom_override_template.html
Review comment:
The idea with adding the gitignore entry was so that
1. There is an example file
2. The file is tracked, but future changes to the file are not. This allows users to add changes to the file without needing to commit those changes or manage that diff.
3. Changes can be committed via `git add -f superset/templates/custom_override_template.html` if necessary.
Though I see how this is could likely become source of confusion for those unfamiliar with this pattern. I'll remove the gitignore entry.
How does `tails_js_custom_extra.html` sound? To me`tai_js_extra.html` sounds like an internal name and not really like a vector for customization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #12315: feat: provide config to insert html tags on every view
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755787917
@ktmud When we do eventually move to a single page app we can just do a `document.insertAdjacentHTML('beforeEnd', HTML_TEMPLATE_SCRIPT)` as part of the app initialization step in the preamble https://github.com/apache/superset/blob/8f7c7d43a3cfc71e5a58bbe317f65626f839f830/superset-frontend/src/preamble.ts#L32
Or in the template we do end up using for all our views (assuming we haven't completely moved off flask/jinja by then)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (be9b8aa) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.55%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.55% +0.55%
==========================================
Files 1002 485 -517
Lines 49286 29881 -19405
Branches 5010 0 -5010
==========================================
- Hits 31049 18990 -12059
+ Misses 18035 10891 -7144
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.55% <100.00%> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (+0.10%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...be9b8aa](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (f169112) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.57%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.56% +0.57%
==========================================
Files 1002 485 -517
Lines 49286 29879 -19407
Branches 5010 0 -5010
==========================================
- Hits 31049 18994 -12055
+ Misses 18035 10885 -7150
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.56% <100.00%> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.72% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...f169112](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756318188
> I disagree with the concerns raised about security, a compromise of app.config is a full pwn in any way we slice it.
Maybe I wasn't clear. It is true that a comprised `app.config` is very serious, but that only means attackers will have access to db credentials and access to datasources **Superset** can connect to---it doesn't mean attackers can access **other internal systems** via **any user's credentials** that are possibly behind an VPN. When you add the ability to write **arbitrary** content to the HTML page, it opens a whole new flood gate. I'll admit such attack is rare, but it doesn't seem worth the risk if we do have another feasible path for the business needs in question.
> I don't think replacing a file before building the frontend will work for our use case given that we're relying on the render_template_string to populate a few values in the script (eg, current_user.id).
You can easily add such info to the bootstrap data. In fact, in a full backend-frontend separated architecture, you would want to add that info to the bootstrap data.
Finally, even if we want to implement this in Jinja template, we can also add a blank overridable template file and use Jinja's `include ignore missing`:
```jinja
{%include "footer_extra.html" ignore missing %}
```
This way you also get syntax highlighting for free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0e31413) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.59% +0.60%
==========================================
Files 1002 485 -517
Lines 49286 29886 -19400
Branches 5010 0 -5010
==========================================
- Hits 31049 19007 -12042
+ Misses 18035 10879 -7156
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.59% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0e31413](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0736278) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
- Coverage 62.99% 62.93% -0.07%
==========================================
Files 1002 1001 -1
Lines 49286 49367 +81
Branches 5010 5033 +23
==========================================
+ Hits 31049 31068 +19
- Misses 18035 18092 +57
- Partials 202 207 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.99% <ø> (-0.22%)` | :arrow_down: |
| python | `64.19% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Hotkeys.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSG90a2V5cy5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `58.97% <0.00%> (-41.03%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SaveQuery.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS50c3g=) | `72.72% <0.00%> (-15.37%)` | :arrow_down: |
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | `71.42% <0.00%> (-14.29%)` | :arrow_down: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `66.66% <0.00%> (-3.71%)` | :arrow_down: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `47.61% <0.00%> (-2.39%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.01% <0.00%> (-0.88%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `92.68% <0.00%> (-0.87%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `67.56% <0.00%> (-0.62%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0736278](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756295935
@ktmud superset currently has an events tracking system where events are relayed to a backend system, which can then relayed to a generic events tracking system. My example of google analytics was probably not the best. Full context, we will be using this config to add [pendo](https://support.pendo.io/hc/en-us/articles/360031862272-Installation-for-Single-Page-Frameworkshttps://support.pendo.io/hc/en-us/articles/360031862272-Installation-for-Single-Page-Frameworks) which mentions not needing any special config for single-page apps. Something like (intercom)[https://www.intercom.com/] or [fullstory](https://www.fullstory.com/) would work similarly.
I don't think replacing a file before building the frontend will work for our use case given that we're relying on the `render_template_string` to populate a few values in the script (eg, current_user.id).
re: security, I'll add the disclaimer to the config file. This does open up a potential attack vector, however there are many other ways in which people configuring superset can shoot themselves in the foot. In general people configuring and deploying and app should be aware of what they're doing, especially in prod-like environments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755914927
@ktmud, I wanted to point out that if `app.config` is accessible/compromised, the whole app is compromised at that point and the `HTML_TEMPLATE_SCRIPT` would be *at best* a convenient hook to do certain things.
Generally I'm bullish on letting people adding hooks that are unlikely to be used by most especially if we add a note/disclaimer to "use with caution". @nytai maybe you can add a note to that effect in `config.py`. Generally we can trust that administrator should know what they're doing.
I know there are many dom-based tools that are pretty smart about monitoring url history for changes. From the page you linked to above:
```
Note: Developers creating Single Page Applications can use autotrack, which includes a urlChangeTracker plugin that handles all of the important considerations listed in this guide for you. See the autotrack documentation for usage and installation instructions.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12315: feat: provide config to insert html tags in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755841589
My concern was more about how you would inject the tracking for SPA page transitions and other user events? You will eventually need a way to allow the inserted script to hook up to some page transition events or let the SPA call the tracking API.
It doesn't seem worth it to add this tag to Jinja (which we are moving away) just to render a static script tag.
Maybe we can add a `setupAppExtra.ts` file that custom deployments can override just like we did for `setupPluginsExtra` and `setupErrorMessagesExtra` (we may also consolidate these files into one).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755780059
# [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=h1) Report
> Merging [#12315](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=desc) (0e31413) into [master](https://codecov.io/gh/apache/superset/commit/8f7c7d43a3cfc71e5a58bbe317f65626f839f830?el=desc) (8f7c7d4) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12315 +/- ##
==========================================
+ Coverage 62.99% 63.54% +0.55%
==========================================
Files 1002 485 -517
Lines 49286 29871 -19415
Branches 5010 0 -5010
==========================================
- Hits 31049 18983 -12066
+ Misses 18035 10888 -7147
+ Partials 202 0 -202
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.54% <ø> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/12315/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=footer). Last update [8f7c7d4...0e31413](https://codecov.io/gh/apache/superset/pull/12315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12315: feat: provide support for a custom_override_template.html to be included in every view
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553656316
##########
File path: superset/templates/superset/basic.html
##########
@@ -104,5 +104,8 @@ <h4 data-test="modal-title" class="modal-title"></h4>
{{ js_bundle(entry) }}
{% endif %}
{% endblock %}
+ {% block custom_template %}
Review comment:
Can we just move the `include` into `block tail_js` like in `base.html`? I'm not sure why this file need a new block but the other one does not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org