[jira] [Resolved] (HDFS-14542) Remove redundant code when verify quota

["Jinglun (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jinglun resolved HDFS-14542.
----------------------------
    Resolution: Duplicate

Thanks [~jojochuang] for your reminding, I'll close this with Resolution: Duplicate.

> Remove redundant code when verify quota
> ---------------------------------------
>
>                 Key: HDFS-14542
>                 URL: https://issues.apache.org/jira/browse/HDFS-14542
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.1.1
>            Reporter: Jinglun
>            Assignee: Jinglun
>            Priority: Minor
>         Attachments: HDFS-14542.patch
>
>
> DirectoryWithQuotaFeature.verifyQuotaByStorageType() does the job of verifying quota. It's redundant to call isQuotaByStorageTypeSet() because the for each iterator nextline has done the same job.
> {code:java}
> private void verifyQuotaByStorageType(EnumCounters<StorageType> typeDelta) 
>      throws QuotaByStorageTypeExceededException {
>   if (!isQuotaByStorageTypeSet()) { // REDUNDANT.
>     return;
>   }
>   for (StorageType t: StorageType.getTypesSupportingQuota()) {
>     if (!isQuotaByStorageTypeSet(t)) { // CHECK FOR EACH STORAGETYPE.
>       continue;
>     }
>     if (Quota.isViolated(quota.getTypeSpace(t), usage.getTypeSpace(t),
>         typeDelta.get(t))) {
>       throw new QuotaByStorageTypeExceededException(
>       quota.getTypeSpace(t), usage.getTypeSpace(t) + typeDelta.get(t), t);
>     }
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org