You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/17 02:46:55 UTC
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3398
to review the following change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Add blog post about removing LocalConsensus
Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
---
A _posts/2016-06-17-raft-consensus-single-node.md
1 file changed, 92 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/3398/1
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Add blog post about removing LocalConsensus
Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Reviewed-on: http://gerrit.cloudera.org:8080/3398
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
Reviewed-by: Jean-Daniel Cryans
---
A _posts/2016-06-17-raft-consensus-single-node.md
1 file changed, 94 insertions(+), 0 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Jean-Daniel Cryans: Looks good to me, approved
Mike Percy: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#3).
Change subject: Add blog post about removing LocalConsensus
......................................................................
Add blog post about removing LocalConsensus
Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
---
A _posts/2016-06-17-raft-consensus-single-node.md
1 file changed, 94 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/3398/3
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Patch Set 1:
(3 comments)
Thanks for the review David. I updated the rendered HTML.
http://gerrit.cloudera.org:8080/#/c/3398/1/_posts/2016-06-17-raft-consensus-single-node.md
File _posts/2016-06-17-raft-consensus-single-node.md:
Line 17: cluster's existing master server replication factor from 1 to 3 (or 5).
> this might confuse people. its perfectly legal to increase to 2 right (just
Done
Line 71: in the future. Kudu fits this use case. When deploying Kudu, someone may wish
> what use case? "Kudu fits..." sounds wrong to me here. I'd remove it
Changed the wording. I don't want people to think they have a choice.
PS1, Line 78: two
> you use words for the numbers here but use the actual numbers in the 2nd pa
Done
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Patch Set 1:
(3 comments)
Thanks for the review JD. I made a couple more tweaks and updated the rendered HTML as well.
http://gerrit.cloudera.org:8080/#/c/3398/1/_posts/2016-06-17-raft-consensus-single-node.md
File _posts/2016-06-17-raft-consensus-single-node.md:
PS1, Line 15: even
> nit: I'd remove that word.
Done
PS1, Line 59: strong
> Is that normal parlance in Raft?
When talking about consensus algorithms, I've heard people say "Raft has a strong leader" but I'm explaining it in the next paragraph so no need to bring it up
PS1, Line 75: a Raft that
> Feels like you're missing a word, maybe a "Raft implementation"? Or "Withou
Yes, thanks for the catch.
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#2).
Change subject: Add blog post about removing LocalConsensus
......................................................................
Add blog post about removing LocalConsensus
Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
---
A _posts/2016-06-17-raft-consensus-single-node.md
1 file changed, 92 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/3398/2
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3398/1/_posts/2016-06-17-raft-consensus-single-node.md
File _posts/2016-06-17-raft-consensus-single-node.md:
Line 17: cluster's existing master server replication factor from 1 to 3 (or 5).
this might confuse people. its perfectly legal to increase to 2 right (just no fault tolerance) just mention from 1 to multiple nodes or something.
Line 71: in the future. Kudu fits this use case. When deploying Kudu, someone may wish
what use case? "Kudu fits..." sounds wrong to me here. I'd remove it
PS1, Line 78: two
you use words for the numbers here but use the actual numbers in the 2nd paragraph
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Patch Set 1:
(3 comments)
I really enjoyed reading this, just minor nits.
http://gerrit.cloudera.org:8080/#/c/3398/1/_posts/2016-06-17-raft-consensus-single-node.md
File _posts/2016-06-17-raft-consensus-single-node.md:
PS1, Line 15: even
nit: I'd remove that word.
PS1, Line 59: strong
Is that normal parlance in Raft?
PS1, Line 75: a Raft that
Feels like you're missing a word, maybe a "Raft implementation"? Or "Without a consensus implementation that"
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add blog post about removing LocalConsensus
......................................................................
Patch Set 1:
Rendered: http://mpercy.github.io/kudu/2016/06/17/raft-consensus-single-node.html
--
To view, visit http://gerrit.cloudera.org:8080/3398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No