[GitHub] [pinot] walterddr commented on a diff in pull request #9044: Add a new workflow to check vulnerabilities using trivy

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9044:
URL: https://github.com/apache/pinot/pull/9044#discussion_r923443744


##########
.github/workflows/pinot_vuln_check.yml:
##########
@@ -0,0 +1,66 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Pinot Dependencies
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+    paths-ignore:
+      - "contrib/**"
+      - "docs/**"
+      - "licenses/**"
+      - "licenses-binary/**"
+      - "**.md"
+jobs:
+  verify-docker:
+    name: Verify Docker Image
+    runs-on: ubuntu-latest
+    steps:
+      - uses: docker/setup-qemu-action@v1
+        name: Set up QEMU
+      - uses: docker/setup-buildx-action@v1
+        name: Set up Docker Buildx
+      - uses: actions/checkout@v3
+      - name: Build the Docker image
+        env:
+          DOCKER_FILE_BASE_DIR: "docker/images/pinot"
+          DOCKER_IMAGE_NAME: "apachepinot/pinot"
+          BUILD_PLATFORM: "linux/amd64"
+          PINOT_GIT_URL: ${{ github.event.inputs.gitUrl }}
+          PINOT_BRANCH: ${{ env.GITHUB_REF }}
+          TAGS: ${{ github.sha }}
+        run: .github/workflows/scripts/docker/.pinot_docker_image_build.sh
+
+      - name: Run Trivy vulnerability scanner (sarif)
+        uses: aquasecurity/trivy-action@master
+        with:
+          trivyignores: '.trivyignore'
+          image-ref: 'apachepinot/pinot:${{ github.sha }}'
+          format: 'sarif'
+          output: 'trivy-results.sarif'
+          vuln-type: 'os,library'
+          severity: 'CRITICAL,HIGH'
+      - name: Upload Trivy scan results to GitHub Security tab
+        uses: github/codeql-action/upload-sarif@v2

Review Comment:
   i see. so if I understand correctly:
   - the reason why this PR has so many vulns is b/c current master doesn't have a baseline vulnerability SARIF result.
   - once merged, the first commit on master will have a large SARIF but the next one should be empty if it didn't modify any dependencies. correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org