You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/07 11:54:13 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #746: arch:
arm: cxd56xx: nxstyle fixes
jerpelea opened a new pull request #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746
nxstyle fixes for cxd56xx
Signed-off-by: Alin Jerpelea <al...@sony.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #746: arch: arm:
cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746#issuecomment-610372603
> I fixed the new warning
Looks good. Now only the expected "Mixed case identifier" errors. I will merge the PR when all of the checks complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #746: arch: arm:
cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746#issuecomment-610397493
@patacongo thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #746: arch: arm:
cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746#issuecomment-610362826
@xiaoxiang781216 I can not see them on a local check
tools/nxstyle arch/arm/src/cxd56xx/cxd56_powermgr.c
arch/arm/src/cxd56xx/cxd56_powermgr.c:988:6: error: Mixed case identifier found
arch/arm/src/cxd56xx/cxd56_powermgr.c:989:6: error: Mixed case identifier found
arch/arm/src/cxd56xx/cxd56_powermgr.c:994:6: error: Mixed case identifier found
arch/arm/src/cxd56xx/cxd56_powermgr.c:997:6: error: Mixed case identifier found
arch/arm/src/cxd56xx/cxd56_powermgr.c:1015:7: error: Mixed case identifier found
arch/arm/src/cxd56xx/cxd56_powermgr.c:1016:2: error: Mixed case identifier found
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #746: arch: arm:
cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746#issuecomment-610366956
> I can not see them on a local check
Because you probably do not have the latest nxstyle. I commited a change yesterday for a violation that was not being detected by nxstyle. I re-ran a large from of tests and found 49, new, valid complaints ( #743 and #744)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #746: arch: arm:
cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #746: arch:
arm: cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746#issuecomment-610345856
@jerpelea there is still some "Long line" warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #746: arch: arm:
cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746#issuecomment-610363227
tools/nxstyle arch/arm/src/cxd56xx/cxd56_powermgr.h
nothing returned
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #746: arch:
arm: cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746#issuecomment-610366956
> I can not see them on a local check
Because you probably do not have the latest nxstyle. I commited a change yesterday for a violation that was not being detected by nxstyle. I re-ran a large from of tests and found 49, new, valid complaints ( #743 and #744)
Perhaps you need to rebase your branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #746: arch: arm:
cxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #746: arch: arm: cxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/746#issuecomment-610367498
@patacongo I was suspecting the same and the error popped after a fetch
Thanks for pointing it
I fixed the new warning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services