[GitHub] [ozone] smengcl edited a comment on pull request #1892: HDDS-4791. StateContext.getReports may return list with size larger t…

[GitBox <gi...@apache.org>]

smengcl edited a comment on pull request #1892:
URL: https://github.com/apache/ozone/pull/1892#issuecomment-784989198


   Thanks @symious for the patch. Yes this was an oversight.
   
   I have the same concern as @adoroszlai mentioned. `maxLimit - nonIncrementalReports.size() < 0` can be a problem.
   
   I agree that we should just remove the `maxLimit` param from `getReports()`:
   
   https://github.com/apache/ozone/blob/6b67ae0c40110af195b897fb70a87dc6e82d467e/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java#L327-L330
   
   and put `getIncrementalReports(endpoint, Integer.MAX_VALUE - nonIncrementalReports.size())` inside.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org