You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Travis P <sv...@castle.fastmail.fm> on 2005/03/25 21:46:53 UTC
Watch Subversion server deadlock with hook script
This pre-commit hook will do it (on a RH 7.2 Linux system in
particular, but most Un*xes will display this behavior though the exact
size at which the pipe is full will vary, 10K works for this Linux
system, but based on Posix limit PIPE_BUF, I'd guess my AIX system will
hold at least 32K before such a deadlock):
#!/usr/bin/perl
my $xs = 'x' x (10*1024); # 10K of data
print STDERR $xs;
exit(1);
Subversion's server should not assume that the pipe is
large enough to hold all the output from the hook script(s)
before it will read any of it.
I'd call this behavior a bug.
-Travis Pouarz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Watch Subversion server deadlock with hook script
Posted by Travis P <sv...@castle.fastmail.fm>.
On Mar 25, 2005, at 3:51 PM, Erik Huelsmann wrote:
> You mean this one:
> http://subversion.tigris.org/issues/show_bug.cgi?id=2078 ?
Yep. I plead *guilty* to not checking the bug database! (I'm not sure
why that thought
didn't cross my mind this time.) Thanks!
I'm going to have to put some checking into my hook since the blocking
limit on my Linux server is 4096 bytes exactly (and exactly equal to
PIPE_BUF, though I don't see that that has to be the case, it often
might be). 4096 doesn't block. 4097 does. That's not that large. If
users do something like illegally touch every file such that they all
violate the pre-commit check. I don't want to allow them to lock up
the server and need to call me (or kill -9 their 'svn commit' command).
-Travis Pouarz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Watch Subversion server deadlock with hook script
Posted by Erik Huelsmann <eh...@gmail.com>.
> This pre-commit hook will do it (on a RH 7.2 Linux system in
> particular, but most Un*xes will display this behavior though the exact
> size at which the pipe is full will vary, 10K works for this Linux
> system, but based on Posix limit PIPE_BUF, I'd guess my AIX system will
> hold at least 32K before such a deadlock):
[snip]
> Subversion's server should not assume that the pipe is
> large enough to hold all the output from the hook script(s)
> before it will read any of it.
>
> I'd call this behavior a bug.
>
You mean this one:
http://subversion.tigris.org/issues/show_bug.cgi?id=2078
?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org