You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/16 13:43:23 UTC
[GitHub] [spark] gengliangwang opened a new pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
gengliangwang opened a new pull request #33751:
URL: https://github.com/apache/spark/pull/33751
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently when casting invalid string to year-month interval, Spark always throws an exception, with/without ANSI mode enabled.
This should only happen when ANSI mode is on. When ANSI mode is off, Spark should return null for invalid cast.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Make it consistent with the other data type cast.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, the new interval type is not released yet.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899524926
**[Test build #142510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142510/testReport)** for PR 33751 at commit [`7a03c24`](https://github.com/apache/spark/commit/7a03c24491af59c76744d791d76e06d68fe37b3f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899552755
**[Test build #142511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142511/testReport)** for PR 33751 at commit [`7a03c24`](https://github.com/apache/spark/commit/7a03c24491af59c76744d791d76e06d68fe37b3f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899595580
> As far as I know we implemented ANSI intervals in some kind of strict mode (ANSI mode) everywhere, and ignored the ANSI mode SQL config.
@MaxGekk I was testing the new interval type manually this afternoon. This cast behavior looks odd to me.
Could you provide examples of features implemented as ANSI mode by default?
I am OK to mark this as "won't do" if we do have other such implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899597440
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47012/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899614009
> Could you provide examples of features implemented as ANSI mode by default?
@gengliangwang Look at any expression in `intervalExpressions.scala` that operates over ANSI interval types. It throws the arithmetic overflow exception by default independently from the SQL config, for instance. For `CalendarIntervalType`, we throw such exception only when `spark.sql.ansi.enabled` is `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899553512
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47011/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899584176
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47012/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #33751:
URL: https://github.com/apache/spark/pull/33751#discussion_r689550016
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
##########
@@ -224,9 +224,8 @@ trait BaseScriptTransformationExec extends UnaryExecNode {
data => IntervalUtils.stringToInterval(UTF8String.fromString(data)),
converter)
case YearMonthIntervalType(start, end) => wrapperConvertException(
- data => IntervalUtils.monthsToPeriod(
- IntervalUtils.castStringToYMInterval(UTF8String.fromString(data), start, end)),
- converter)
+ data => IntervalUtils.castStringToYMInterval(UTF8String.fromString(data), start, end)
+ .map(IntervalUtils.monthsToPeriod).orNull, converter)
Review comment:
This is following string to date logic in BaseScriptTransformationExec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899551477
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899597798
well, if there are a lot of interval operations that follow ANSI semantic now, then it's not realistic to change them all, and we should just polish the migration guide to mention this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899573122
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142511/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899566916
@cloud-fan I have created https://issues.apache.org/jira/browse/SPARK-36523 for the day-time interval.
The method `castStringToYMInterval` is used in multiple places. I think making a separate PR for each type is cleaner and easier for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899621243
Got it. I am closing this PR and related JIRAs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #33751:
URL: https://github.com/apache/spark/pull/33751#discussion_r689594580
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -204,7 +219,7 @@ object IntervalUtils {
*/
def fromYearMonthString(input: String, startField: Byte, endField: Byte): CalendarInterval = {
require(input != null, "Interval year-month string must be not null")
- val months = castStringToYMInterval(UTF8String.fromString(input), startField, endField)
+ val months = castStringToYMIntervalAnsi(UTF8String.fromString(input), startField, endField)
Review comment:
This one is used in the type constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899545402
jenkins, retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899551477
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899552755
**[Test build #142511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142511/testReport)** for PR 33751 at commit [`7a03c24`](https://github.com/apache/spark/commit/7a03c24491af59c76744d791d76e06d68fe37b3f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899553512
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47011/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899580421
> Why are the changes needed?
> Make it consistent with the other data type cast.
I don't think this is the right reason. Since we turn on ansi interval types by default, I think it's better to avoid breaking changes when not necessary. If the new types are opt-in (like timestamp ntz), then that's a different story.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899553468
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47011/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899573122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899524926
**[Test build #142510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142510/testReport)** for PR 33751 at commit [`7a03c24`](https://github.com/apache/spark/commit/7a03c24491af59c76744d791d76e06d68fe37b3f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899557480
Can we fix day-time interval in this PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #33751:
URL: https://github.com/apache/spark/pull/33751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899529098
**[Test build #142510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142510/testReport)** for PR 33751 at commit [`7a03c24`](https://github.com/apache/spark/commit/7a03c24491af59c76744d791d76e06d68fe37b3f).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33751:
URL: https://github.com/apache/spark/pull/33751#issuecomment-899573025
**[Test build #142511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142511/testReport)** for PR 33751 at commit [`7a03c24`](https://github.com/apache/spark/commit/7a03c24491af59c76744d791d76e06d68fe37b3f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org