You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 15:45:58 UTC
[GitHub] [flink] zentol opened a new pull request #11259:
[FLINK-15633][build] Bump javadoc-plugin to 3.1.1
zentol opened a new pull request #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259
Bumps the javadoc-plugin to 3.1.1, as earlier versions don't work on Java 11.
`additionalparam` was replaced in 3.0.0 (see MJAVADOC-475) with `additionalJOptions` with which you can better define arguments as lists, which is actually quite nice.
The extra configuration in the java11 profile is necessary as without it the javadoc-plugin failed on `org.apache.flink.util.NetUtils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11259: [FLINK-15633][build]
Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#issuecomment-592584676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c10eb16358b60ff133f2e970712f5723720ccea0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11259:
[FLINK-15633][build] Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#discussion_r385811657
##########
File path: pom.xml
##########
@@ -929,6 +929,15 @@ under the License.
<excludedGroups>org.apache.flink.testutils.junit.FailsOnJava11</excludedGroups>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <additionalJOptions>
+ <additionalJOption>--add-exports=java.base/sun.net.util=ALL-UNNAMED</additionalJOption>
Review comment:
Could you quickly explain what this does?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11259:
[FLINK-15633][build] Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#discussion_r385813940
##########
File path: pom.xml
##########
@@ -929,6 +929,15 @@ under the License.
<excludedGroups>org.apache.flink.testutils.junit.FailsOnJava11</excludedGroups>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <additionalJOptions>
+ <additionalJOption>--add-exports=java.base/sun.net.util=ALL-UNNAMED</additionalJOption>
Review comment:
It makes one of the internal jdk packages accessible at runtime to my understanding.
We need the same thing for the `maven-compiler-plugin` (although curiously not in dist....).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11259: [FLINK-15633][build]
Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#issuecomment-592572869
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c10eb16358b60ff133f2e970712f5723720ccea0 (Fri Feb 28 15:49:41 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11259:
[FLINK-15633][build] Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#issuecomment-592572869
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c10eb16358b60ff133f2e970712f5723720ccea0 (Fri Feb 28 21:50:13 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11259:
[FLINK-15633][build] Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#discussion_r385813940
##########
File path: pom.xml
##########
@@ -929,6 +929,15 @@ under the License.
<excludedGroups>org.apache.flink.testutils.junit.FailsOnJava11</excludedGroups>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <additionalJOptions>
+ <additionalJOption>--add-exports=java.base/sun.net.util=ALL-UNNAMED</additionalJOption>
Review comment:
It makes one of the internal jdk modules accessible at runtime to my understanding.
We need the same thing for the `maven-compiler-plugin` (although curiously not in dist....).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11259:
[FLINK-15633][build] Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#issuecomment-592584676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5752",
"triggerID" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"triggerType" : "PUSH"
}, {
"hash" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151053003",
"triggerID" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c10eb16358b60ff133f2e970712f5723720ccea0 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151053003) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5752)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11259:
[FLINK-15633][build] Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#issuecomment-592584676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5752",
"triggerID" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"triggerType" : "PUSH"
}, {
"hash" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151053003",
"triggerID" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c10eb16358b60ff133f2e970712f5723720ccea0 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151053003) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5752)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11259: [FLINK-15633][build]
Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11259:
[FLINK-15633][build] Bump javadoc-plugin to 3.1.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11259: [FLINK-15633][build] Bump javadoc-plugin to 3.1.1
URL: https://github.com/apache/flink/pull/11259#issuecomment-592584676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5752",
"triggerID" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"triggerType" : "PUSH"
}, {
"hash" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151053003",
"triggerID" : "c10eb16358b60ff133f2e970712f5723720ccea0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c10eb16358b60ff133f2e970712f5723720ccea0 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151053003) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5752)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services