You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by chenliang613 <gi...@git.apache.org> on 2015/08/27 12:14:24 UTC
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
GitHub user chenliang613 opened a pull request:
https://github.com/apache/flink/pull/1068
[FLINK-2493] Simplify names of example program JARs
The names of example JARs have a bit annoying, propose to replace
"examples/flinnk-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar"
with "examples/ConnectedComponents.jar"
1. Changing java and scala examples' pom.xml, set finalName to replace
default name "artifactId+version+classifer".
2.update quickstart doc which referring to examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenliang613/flink FLINK-2493
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1068
----
commit 741c846584936a8caca25269cf22cee4f0e3fa6e
Author: unknown <c0...@szxy1c002460671.china.huawei.com>
Date: 2015-08-27T10:02:51Z
[FLINK-2493] Simplify names of example program JARs
commit 658ffad9e20a511c9c377fbf438c54521291ea50
Author: unknown <c0...@szxy1c002460671.china.huawei.com>
Date: 2015-08-27T10:12:15Z
[FLINK-2493] Simplify names of example program JARs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1068#issuecomment-137095444
@chenliang613 Do you want to open another poll request with the fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1068#issuecomment-135426825
Here is a reference to the CI result: https://s3.amazonaws.com/archive.travis-ci.org/jobs/77474252/log.txt
You can always run `mvn clean verify` locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 closed the pull request at:
https://github.com/apache/flink/pull/1068
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/1068#issuecomment-135591554
@StephanEwen sure! actually i did the "verify operation" at local machine.
At my local machine's log msg showing: got reference jar(as below)from central repository of Maven,so it could build successfully.
Downloading: http://repository.apache.org/snapshots/org/apache/flink/flink-java-examples/0.10-SNAPSHOT/flink-java-examples-0.10-20150827.224410-137.jar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/1068#issuecomment-135580675
@mbalassi OK, i will make changes for flink-streaming-examples and flink-storm-compatibility-example modules too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1068#issuecomment-135420490
Thanks for picking up the issue. Could you make the changes for the `flink-streaming-examples` and the `flink-storm-compatibility-example` modules too, please? Also travis suggests you have unintentionally broken some references.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/1068#issuecomment-137098642
@StephanEwen yes. may use another solution :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---