[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5884: feat: hyperbolic functions

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5884:
URL: https://github.com/apache/arrow-datafusion/pull/5884#discussion_r1160630022


##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -683,6 +683,12 @@ async fn test_mathematical_expressions_with_null() -> Result<()> {
     test_expression!("asin(NULL)", "NULL");
     test_expression!("acos(NULL)", "NULL");
     test_expression!("atan(NULL)", "NULL");
+    test_expression!("sinh(NULL)", "NULL");

Review Comment:
   I am sorry if I missed it in my review, but are these new functions tested with non null inputs?
   
   Specifically it would be great to see a sql level test that invoked them with values



##########
docs/source/user-guide/sql/scalar_functions.md:
##########
@@ -110,6 +155,19 @@ atan2(expression_y, expression_x)
 - **expression_x**: Second numeric expression to operate on.
   Can be a constant, column, or function, and any combination of arithmetic operators.
 
+### `cbrt`
+
+Returns the cube root of a number.

Review Comment:
   Thank you for cleaning this up in "drive by" fashion 👍 



##########
docs/source/user-guide/sql/scalar_functions.md:
##########
@@ -110,6 +155,19 @@ atan2(expression_y, expression_x)
 - **expression_x**: Second numeric expression to operate on.
   Can be a constant, column, or function, and any combination of arithmetic operators.
 
+### `cbrt`
+
+Returns the cube root of a number.

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org