[GitHub] [arrow] TheNeuralBit commented on a change in pull request #8385: ARROW-10220 [Javascript] Javascript toArray() method ignores nulls on some types.

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#discussion_r562374331



##########
File path: js/src/visitor/toarray.ts
##########
@@ -88,18 +88,6 @@ export class ToArrayVisitor extends Visitor {}
 
 /** @ignore */
 function arrayOfVector<T extends DataType>(vector: VectorType<T>): T['TArray'] {
-
-    const { type, length, stride } = vector;
-
-    // Fast case, return subarray if possible
-    switch (type.typeId) {

Review comment:
       Instead of removing the fast case can you just add a check to skip this if the type is nullable? As you pointed out in the jira we could still do this for non-nullable arrays.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org