You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "Similarityoung (via GitHub)" <gi...@apache.org> on 2024/12/18 15:47:18 UTC
[PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Similarityoung opened a new pull request, #745:
URL: https://github.com/apache/incubator-seata-go/pull/745
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Delete the logs generated by fence and use limit to restrict the number of deletions each time.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #699
**Special notes for your reviewer**: null
**Does this PR introduce a user-facing change?**: no
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "Similarityoung (via GitHub)" <gi...@apache.org>.
Similarityoung commented on code in PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#discussion_r1967169637
##########
pkg/rm/tcc/fence/store/db/sql/tcc_fence_store_sql.go:
##########
@@ -28,20 +28,32 @@ var (
// localTccLogPlaced The enum LocalTccLogPlaced
localTccLogPlaced = " %s "
+ pramPlaceHolder = "%s "
+
// insertLocalTccLog The enum InsertLocalTccLog
insertLocalTccLog = "insert into " + localTccLogPlaced + " (xid, branch_id, action_name, status, gmt_create, gmt_modified) values ( ?,?,?,?,?,?)"
// queryByBranchIdAndXid The enum QueryByBranchIdAndXid
queryByBranchIdAndXid = "select xid, branch_id, action_name, status, gmt_create, gmt_modified from " + localTccLogPlaced + " where xid = ? and branch_id = ? for update"
+ // queryByMdDate The enum QueryByMdDate
+ queryByMdDate = "select xid, branch_id from " + localTccLogPlaced + " where gmt_modified < ? " +
+ " and status in (" + strconv.Itoa(int(enum.StatusCommitted)) + " , " + strconv.Itoa(int(enum.StatusRollbacked)) + " , " + strconv.Itoa(int(enum.StatusSuspended)) + ")"
+
// updateStatusByBranchIdAndXid The enum UpdateStatusByBranchIdAndXid
updateStatusByBranchIdAndXid = "update " + localTccLogPlaced + " set status = ?, gmt_modified = ? where xid = ? and branch_id = ? and status = ? "
// deleteByBranchIdAndXid The enum DeleteByBranchIdAndXid
deleteByBranchIdAndXid = "delete from " + localTccLogPlaced + " where xid = ? and branch_id = ? "
+ // deleteByBranchIdsAndXids The enum DeleteByBranchIdsAndXids
+ deleteByBranchIdsAndXids = "delete from " + localTccLogPlaced + " where (xid,branch_id) in (" + pramPlaceHolder + ")"
Review Comment:
因为我看之前有删除的 sql 语句就是根据 xid 和 branchid 进行删除的。并且之前PrepareFence 方法中，insertTCCFenceLog 失败后也会把他的 xid 和 branchid放入channel 中用于执行删除语句，所以我是根据 xid 和 branchid 来删除的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#issuecomment-2599683446
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#issuecomment-2558048337
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#issuecomment-2562366183
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745) **Quality Gate passed**
Issues
 [5 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "luky116 (via GitHub)" <gi...@apache.org>.
luky116 commented on code in PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#discussion_r1894589501
##########
pkg/rm/tcc/fence/handler/tcc_fence_wrapper_handler.go:
##########
@@ -163,6 +165,40 @@ func (handler *tccFenceWrapperHandler) InitLogCleanChannel() {
})
}
+func (handler *tccFenceWrapperHandler) InitLogCleanTask(tx *sql.Tx) {
+ handler.logTaskOnce.Do(func() {
+ // Create a ticker that will fire initially based on the time remaining until the next midnight (00:00:00).
+ go func() {
+ ticker := time.NewTicker(getDurationUntilNextZero())
+ defer ticker.Stop()
+
+ for {
+ select {
+ case <-ticker.C:
+ now := time.Now()
+ // Get the start time of the day before the current day (00:00:00) and assign it to timeBefore with the same location as now.
+ timeBefore := time.Date(now.Year(), now.Month(), now.Day()-1, 0, 0, 0, 0, now.Location())
+
+ for {
+ deletedRowCount, err := handler.tccFenceDao.DeleteTCCFenceDOByMdfDate(tx, timeBefore, limitDelete)
+ if err != nil {
+ fmt.Printf("Error occurred during TCC fence clean task: %v\n", err)
Review Comment:
这种方式还有个问题，如果网络抖动一次，当前的删除工作就终止的
##########
pkg/rm/tcc/fence/handler/tcc_fence_wrapper_handler.go:
##########
@@ -163,6 +165,40 @@ func (handler *tccFenceWrapperHandler) InitLogCleanChannel() {
})
}
+func (handler *tccFenceWrapperHandler) InitLogCleanTask(tx *sql.Tx) {
+ handler.logTaskOnce.Do(func() {
+ // Create a ticker that will fire initially based on the time remaining until the next midnight (00:00:00).
+ go func() {
+ ticker := time.NewTicker(getDurationUntilNextZero())
+ defer ticker.Stop()
+
+ for {
+ select {
+ case <-ticker.C:
+ now := time.Now()
+ // Get the start time of the day before the current day (00:00:00) and assign it to timeBefore with the same location as now.
+ timeBefore := time.Date(now.Year(), now.Month(), now.Day()-1, 0, 0, 0, 0, now.Location())
+
+ for {
+ deletedRowCount, err := handler.tccFenceDao.DeleteTCCFenceDOByMdfDate(tx, timeBefore, limitDelete)
+ if err != nil {
+ fmt.Printf("Error occurred during TCC fence clean task: %v\n", err)
Review Comment:
如果采用评论区说的，使用channel，见听到一定条数删除一次，看看会有啥啥问题不
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "Similarityoung (via GitHub)" <gi...@apache.org>.
Similarityoung commented on PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#issuecomment-2551733655
佬们，能教教孩子吗
我注意到 java 那里实现方式是先找一千个需要删除的日志，记录 xid 再进行删除，如此循环直到找不出日志为止。
然后我注意到再 go 里面 fence 里有个channel : traversalCleanChannel是用来放需要删除日志的 xid和 brandId 的。我有考虑过直接通过定时任务查询需要删除的日志，把他们的 xid 和 brandId 放进这个 channel 中。但是我感觉这样通过 channel 一次删除一条日志的效率太低了。
所以我就重新写了一个定时任务，在每天零点的时候执行，也没有查找日志再删除，而是直接进行日志删除，并采用循环直到没有日志需要删除。
最后我的问题是：
1. 我这样设计是否合理，我有考虑另一种方式实现：先查询日志，再一个个插入进 channel 中，然后 channel 一次性删除多条日志。
2. 目前我写完了那个定时任务，但是我不知道，在 fence初始化的哪里对这个定时任务进行调用
3. 目前我只对删除 sql 进行了测试，对于定时任务的测试我不是很清楚该如何测试
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "Code-Fight (via GitHub)" <gi...@apache.org>.
Code-Fight merged PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "luky116 (via GitHub)" <gi...@apache.org>.
luky116 commented on code in PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#discussion_r1894589397
##########
pkg/rm/tcc/fence/handler/tcc_fence_wrapper_handler.go:
##########
@@ -163,6 +165,40 @@ func (handler *tccFenceWrapperHandler) InitLogCleanChannel() {
})
}
+func (handler *tccFenceWrapperHandler) InitLogCleanTask(tx *sql.Tx) {
+ handler.logTaskOnce.Do(func() {
+ // Create a ticker that will fire initially based on the time remaining until the next midnight (00:00:00).
+ go func() {
+ ticker := time.NewTicker(getDurationUntilNextZero())
+ defer ticker.Stop()
+
+ for {
+ select {
+ case <-ticker.C:
+ now := time.Now()
+ // Get the start time of the day before the current day (00:00:00) and assign it to timeBefore with the same location as now.
+ timeBefore := time.Date(now.Year(), now.Month(), now.Day()-1, 0, 0, 0, 0, now.Location())
+
+ for {
+ deletedRowCount, err := handler.tccFenceDao.DeleteTCCFenceDOByMdfDate(tx, timeBefore, limitDelete)
+ if err != nil {
+ fmt.Printf("Error occurred during TCC fence clean task: %v\n", err)
Review Comment:
日志统一使用 log 来输出
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "Bughue (via GitHub)" <gi...@apache.org>.
Bughue commented on code in PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#discussion_r1967148486
##########
pkg/rm/tcc/fence/store/db/sql/tcc_fence_store_sql.go:
##########
@@ -28,20 +28,32 @@ var (
// localTccLogPlaced The enum LocalTccLogPlaced
localTccLogPlaced = " %s "
+ pramPlaceHolder = "%s "
+
// insertLocalTccLog The enum InsertLocalTccLog
insertLocalTccLog = "insert into " + localTccLogPlaced + " (xid, branch_id, action_name, status, gmt_create, gmt_modified) values ( ?,?,?,?,?,?)"
// queryByBranchIdAndXid The enum QueryByBranchIdAndXid
queryByBranchIdAndXid = "select xid, branch_id, action_name, status, gmt_create, gmt_modified from " + localTccLogPlaced + " where xid = ? and branch_id = ? for update"
+ // queryByMdDate The enum QueryByMdDate
+ queryByMdDate = "select xid, branch_id from " + localTccLogPlaced + " where gmt_modified < ? " +
+ " and status in (" + strconv.Itoa(int(enum.StatusCommitted)) + " , " + strconv.Itoa(int(enum.StatusRollbacked)) + " , " + strconv.Itoa(int(enum.StatusSuspended)) + ")"
+
// updateStatusByBranchIdAndXid The enum UpdateStatusByBranchIdAndXid
updateStatusByBranchIdAndXid = "update " + localTccLogPlaced + " set status = ?, gmt_modified = ? where xid = ? and branch_id = ? and status = ? "
// deleteByBranchIdAndXid The enum DeleteByBranchIdAndXid
deleteByBranchIdAndXid = "delete from " + localTccLogPlaced + " where xid = ? and branch_id = ? "
+ // deleteByBranchIdsAndXids The enum DeleteByBranchIdsAndXids
+ deleteByBranchIdsAndXids = "delete from " + localTccLogPlaced + " where (xid,branch_id) in (" + pramPlaceHolder + ")"
Review Comment:
做清除动作的时候根据xid去做就好了吧？会有同一个xid里的一部分分支要清除，另一部分还留着的诉求吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "luky116 (via GitHub)" <gi...@apache.org>.
luky116 commented on PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#issuecomment-2558057782
> 佬们，能教教孩子吗
>
> 我注意到 java 那里实现方式是先找一千个需要删除的日志，记录 xid 再进行删除，如此循环直到找不出日志为止。
>
> 然后我注意到再 go 里面 fence 里有个channel : traversalCleanChannel是用来放需要删除日志的 xid和 brandId 的。我有考虑过直接通过定时任务查询需要删除的日志，把他们的 xid 和 brandId 放进这个 channel 中。但是我感觉这样通过 channel 一次删除一条日志的效率太低了。
>
> 所以我就重新写了一个定时任务，在每天零点的时候执行，也没有查找日志再删除，而是直接进行日志删除，并采用循环直到没有日志需要删除。
>
> 最后我的问题是：
>
> 1. 我这样设计是否合理，我有考虑另一种方式实现：先查询日志，再一个个插入进 channel 中，然后 channel 一次性删除多条日志。
> 2. 目前我写完了那个定时任务，但是我不知道，在 fence初始化的哪里对这个定时任务进行调用
> 3. 目前我只对删除 sql 进行了测试，对于定时任务的测试我不是很清楚该如何测试
1、短期内，每晚执行删除，每次删除1000条，分多次删除，是可以的；
2、如果使用 traversalCleanChannel ，监听者可以对收到的 traversalCleanChannel 的消息进行计数，如果收到 n 条再执行一次删除，也是可行的
3、第2中方式能保证清理fence 日志的压力分散均匀，可能会更好点
如果后面有其他问题，可以继续优化，短期内先实现一种
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#issuecomment-2551665742
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#issuecomment-2567394989
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize : tccfence log table deleted should be optimized [incubator-seata-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #745:
URL: https://github.com/apache/incubator-seata-go/pull/745#issuecomment-2660885173
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-seata-go&pullRequest=745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org