svn commit: r809777 - /incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AnalysisEngineImplBase.java

[sc...@apache.org]

Author: schor
Date: Mon Aug 31 23:02:45 2009
New Revision: 809777

URL: http://svn.apache.org/viewvc?rev=809777&view=rev
Log:
[UIMA-941] record some 0 length analysis engine times

Modified:
    incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AnalysisEngineImplBase.java

Modified: incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AnalysisEngineImplBase.java
URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AnalysisEngineImplBase.java?rev=809777&r1=809776&r2=809777&view=diff
==============================================================================
--- incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AnalysisEngineImplBase.java (original)
+++ incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AnalysisEngineImplBase.java Mon Aug 31 23:02:45 2009
@@ -545,7 +545,7 @@
   protected void buildProcessTraceFromMBeanStats(ProcessTrace trace) {
     // this is the implementation for primitives only. Aggregate AE overrides.
     if (isProcessTraceEnabled()) {
-      // to accomodate service adapters, check if a Service Call time is registered
+      // to accommodate service adapters, check if a Service Call time is registered
       int serviceCallTime = (int) getMBean().getServiceCallTimeSinceMark();
       ProcessTraceEvent_impl serviceCallEvent = null;
       if (serviceCallTime > 0) {
@@ -556,7 +556,16 @@
 
       // now check Analysis time
       int analysisTime = (int) getMBean().getAnalysisTimeSinceMark();
-      if (analysisTime > 0) {
+      if (analysisTime > 0 || 
+          // Jira http://issues.apache.org/jira/browse/uima-941
+          // intent is to skip recording analysis times of 0
+          //   if these are coming from a remote which supports
+          //   serviceCallTime but not analysisTime
+          //   If both are 0, the presumption is that the time really
+          //   was 0.  If only analysisTime is 0, the presumption is
+          //   that the remote didn't implement it, in favor of
+          //   returning serviceCallTime.
+          (analysisTime == 0 && serviceCallTime == 0)) {
         ProcessTraceEvent_impl analysisEvent = new ProcessTraceEvent_impl(getMetaData().getName(),
                 "Analysis", "");
         analysisEvent.setDuration(analysisTime);